This repository has been archived by the owner on Mar 12, 2024. It is now read-only.
Minor changes #364
Open
Minor changes #364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added some comments + automatic precision (torch 1.6+). Added some restart features - saving of the dataset prior to dataloaders this way dataset doesn't need loading again. You add these changes if you want.
I certainly learned a lot from your code. There's some stuff like how you are using positional encoders with image box locations which was confusing. Seems like you are using the masking? Would you be able to elaborate on that in the readme? The paper doesn't completely describe what you guys are doing.