Skip to content
This repository has been archived by the owner on Mar 12, 2024. It is now read-only.

Correcting incorrect types #296

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

zhiqwang
Copy link
Contributor

@zhiqwang zhiqwang commented Nov 30, 2020

Due to torchscript support torch.device now, I updated the Device to torch.device

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 30, 2020
@zhiqwang
Copy link
Contributor Author

Hi, It's unexpected that the modification of type Device to torch.device would affect a lot in the unittest, so I closed it );

@zhiqwang zhiqwang closed this Nov 30, 2020
@zhiqwang zhiqwang reopened this Nov 30, 2020
@zhiqwang
Copy link
Contributor Author

Learned from pytorch/vision#3059, I used string for class name annotation to avoid type annotation error, but there is also a segmentation fault ;(

@fmassa
Copy link
Contributor

fmassa commented Nov 30, 2020

Hi,

Thanks for the PR!

I checked the CI logs from DETR, and in here pip is picking the nightly from Nov 29, while pytorch/vision#3059 is taking (via conda) the nightly from Nov 30, which might explain the segfault.

This means that maybe if we try re-running the tests in a couple of days the segfault should disappear.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants