-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#5 Feat: Implement Pipeline Builder for ease of pipeline creation #37
Open
botirk38
wants to merge
11
commits into
facebookresearch:main
Choose a base branch
from
botirk38:feature/pipeline-builder
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
#5 Feat: Implement Pipeline Builder for ease of pipeline creation #37
botirk38
wants to merge
11
commits into
facebookresearch:main
from
botirk38:feature/pipeline-builder
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
label
Aug 23, 2024
botirk38
changed the title
Feat: Implement Pipeline Builder for ease of pipeline creation
#5 Feat: Implement Pipeline Builder for ease of pipeline creation
Aug 23, 2024
artemru
reviewed
Sep 3, 2024
FileNotFoundError: If the configuration file is not found. | ||
|
||
""" | ||
config_file = self.config_dir / f"{dataset_name}/{operation}.yaml" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you add an example of such cards ?
btw, please look how it's done in sonar with model cards (where all loading logic is already done)
Are we going to merge this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
This feature is needed to streamline the creation of machine learning pipelines based on configuration files for different operations. By implementing this
PipelineBuilder
class, we can dynamically load configurations and create pipelines specific to the tasks such as text-to-embedding, embedding-to-text, text segmentation, and metric analysis. This makes the process of pipeline creation more modular, maintainable, and extensible, catering to different datasets and operations in a standardized way.Use Case:
How?
Technical Decisions:
Directory Structure:
config_dir
defaults tohuggingface_pipelines/datacards
. This directory is assumed to contain subdirectories for each dataset, where operation-specific YAML configuration files are stored.Factory Pattern:
TextToEmbeddingPipelineFactory
) that is responsible for creating the pipeline based on the configuration.pipeline_factories
dictionary.Configuration Loading:
FileNotFoundError
is raised with an appropriate error message logged.Pipeline Creation:
create_pipeline
method dynamically loads the configuration and uses the appropriate factory to create the pipeline.Work In Progress:
audio_preprocessing
), corresponding factory classes and YAML configurations must be created.Test Plan
Unit Testing:
PipelineBuilder
class to verify:Command Line Testing:
Integration Testing:
PipelineBuilder
into the main application workflow and verified that pipelines are correctly built and executed for real datasets.