Fixing header files #127
Closed
Fixing header files #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D67958287 |
|
This pull request was exported from Phabricator. Differential Revision: D67958287 |
macvincent
pushed a commit
to macvincent/nimble
that referenced
this pull request
Jan 9, 2025
Summary: Pull Request resolved: facebookincubator#127 A new Open Source requirements task T211952563 was created for nimble. This diff completes the remaining header fixes: P1709225538 There are 6 files in the list that do not require more headers. I will add those to the exceptions list. Differential Revision: D67958287
macvincent
force-pushed
the
export-D67958287
branch
from
398bd8e to
60093ff
Compare
macvincent
pushed a commit
to macvincent/nimble
that referenced
this pull request
Jan 9, 2025
Summary: Pull Request resolved: facebookincubator#127 A new open source requirements task T211952563 was created for Nimble. This diff completes the remaining header fixes: P1709225538. There are 3 Python and 3 CMAKE files in the list that are not Nimble source files. I will add those to the exceptions list. TODO: A`CONTRIBUTING` file is also required. I will work with the rest of the team on this. Differential Revision: D67958287
macvincent
force-pushed
the
export-D67958287
branch
from
60093ff to
fff4439
Compare
|
This pull request was exported from Phabricator. Differential Revision: D67958287 |
Summary: Pull Request resolved: facebookincubator#127 A new open source requirements task T211952563 was created for Nimble. This diff completes the remaining header fixes: P1709225538. There are 3 CMAKE files in the list that are not Nimble source files. I will add those to the exceptions list. TODO: A`CONTRIBUTING` file is also required. I will work with the rest of the team on this. Differential Revision: D67958287
|
This pull request was exported from Phabricator. Differential Revision: D67958287 |
macvincent
force-pushed
the
export-D67958287
branch
from
fff4439 to
0d8d454
Compare
|
This pull request has been merged in e098251. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Differential Revision: D67958287