lambda.md : Add the lambda flow section #319

santoshmahto7 · 2024-07-24T19:17:34Z

No description provided.

Signed-off-by: Santosh Mahto <[email protected]>

obbardc · 2024-07-25T11:51:26Z

resctl-bench/doc/lambda.md

+1. User generates the benchmark result on their device.
+`$ resctl-bench -r "$RESULT_JSON" --logfile=$LOG_FILE run iocost-tune`
+2. User uploads the result to aws lambda function url as:
+`resctl-bench -r <RESULT_JSON> upload --upload-url  <AWS lambda function URL>`
 e.g  
 `$resctl-bench --result resctl-bench-result_2022_07_01-00_26_40.json.gz upload --upload-url https://ygvr6jnjckwamfao5xztg6idiu0ukjeb.lambda-url.eu-west-1.on.aws`


Need to confirm the URL first.

resctl-bench/doc/README.md

obbardc · 2024-07-25T11:52:21Z

resctl-bench/doc/README.md

@@ -20,6 +20,10 @@ The benchmarks
 * [iocost-qos](iocost-qos.md): Benchmark IO isolation with different io.cost QoS configurations
 * [iocost-tune](iocost-tune.md): Benchmark storage device to determine io.cost QoS solutions

+AWS lambda workflow


Suggested change

AWS lambda workflow

AWS Lambda Result Upload workflow

obbardc · 2024-07-25T11:52:47Z

resctl-bench/doc/lambda.md

 We also store the credential parameters required to file a github issue in AWS Systems Manager -> parameter store.
-We use github app `iocost-issue-creater` to file a github issue, thus it's credentials information `App Id` and 
-`Private Key` are stored in parameter store.  
+Lambda uses github app [iocost-issue-creater](https://github.com/apps/iocost-issue-creater) to file a github issue, thus it's credentials information `App Id` and `Private Key` are stored in AWS parameter store.


Suggested change

Lambda uses github app [iocost-issue-creater](https://github.com/apps/iocost-issue-creater) to file a github issue, thus it's credentials information `App Id` and `Private Key` are stored in AWS parameter store.

The Lambda function uses a GitHub app [iocost-issue-creater](https://github.com/apps/iocost-issue-creater) to file a GitGub issue, thus it's credentials information `App Id` and `Private Key` are stored in the AWS parameter store.

obbardc · 2024-07-25T11:53:21Z

resctl-bench/doc/lambda.md

 e.g  
 `$resctl-bench --result resctl-bench-result_2022_07_01-00_26_40.json.gz upload --upload-url https://ygvr6jnjckwamfao5xztg6idiu0ukjeb.lambda-url.eu-west-1.on.aws`

 3. Lamda is tiggered automatically in AWS.
     - It saves the benchmark result to S3 bucket.
-     - Then create a issue in iocost-benchmark/iocost-benchmarks project using `iocost-issue-creater` github app.
+     - Then creates an issue in [iocost-benchmarks](https://github.com/iocost-benchmark/iocost-benchmarks) project using [iocost-issue-creater](https://github.com/apps/iocost-issue-creater) github app.


Suggested change

- Then creates an issue in [iocost-benchmarks](https://github.com/iocost-benchmark/iocost-benchmarks) project using [iocost-issue-creater](https://github.com/apps/iocost-issue-creater) github app.

- Then creates an issue in the [iocost-benchmarks](https://github.com/iocost-benchmark/iocost-benchmarks) project using [iocost-issue-creater](https://github.com/apps/iocost-issue-creater) GitHub app.

obbardc · 2024-07-25T11:53:33Z

resctl-bench/doc/lambda.md

 e.g  
 `$resctl-bench --result resctl-bench-result_2022_07_01-00_26_40.json.gz upload --upload-url https://ygvr6jnjckwamfao5xztg6idiu0ukjeb.lambda-url.eu-west-1.on.aws`

 3. Lamda is tiggered automatically in AWS.
     - It saves the benchmark result to S3 bucket.
-     - Then create a issue in iocost-benchmark/iocost-benchmarks project using `iocost-issue-creater` github app.
+     - Then creates an issue in [iocost-benchmarks](https://github.com/iocost-benchmark/iocost-benchmarks) project using [iocost-issue-creater](https://github.com/apps/iocost-issue-creater) github app.
     - Issue contain a link to benchmark result stored in s3 bucket.


Suggested change

- Issue contain a link to benchmark result stored in s3 bucket.

- Issue contains a link to the benchmark result stored in an S3 bucket.

obbardc · 2024-07-25T11:55:19Z

resctl-bench/doc/lambda.md


+### Lambda workflow:
+Client uploads the benchmark result (above steps) -> AWS Lambda runs -> save result to s3 bucket -> Create github Issue with link of result stored in s3.


Suggested change

Client uploads the benchmark result (above steps) -> AWS Lambda runs -> save result to s3 bucket -> Create github Issue with link of result stored in s3.

User uploads the benchmark result (following the above steps), the AWS Lambda function runs and saves the result into the S3 bucket, then the Lambda function creates a GitHub Issue with a link to the result stored in the S3 bucket.

obbardc · 2024-07-25T11:56:07Z

resctl-bench/doc/lambda.md


+### Lambda workflow:
+Client uploads the benchmark result (above steps) -> AWS Lambda runs -> save result to s3 bucket -> Create github Issue with link of result stored in s3.
+Thereafter it's job of [iocost-benchmarks project](https://github.com/iocost-benchmark/iocost-benchmarks) to import and merge the results with existing database and generate final hwdb file.


Suggested change

Thereafter it's job of [iocost-benchmarks project](https://github.com/iocost-benchmark/iocost-benchmarks) to import and merge the results with existing database and generate final hwdb file.

The submitted result is further processed by the CI workflows running in the [iocost-benchmarks](https://github.com/iocost-benchmark/iocost-benchmarks/) repository, importing and merging the results with the existing database and finally generating the hwdb file.

Co-authored-by: Christopher Obbard <[email protected]>

lambda.md : Add the lambda flow section for clarity.

174e371

Signed-off-by: Santosh Mahto <[email protected]>

facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 24, 2024

htejun approved these changes Jul 24, 2024

View reviewed changes

obbardc suggested changes Jul 25, 2024

View reviewed changes

Update resctl-bench/doc/README.md

cfdcd34

Co-authored-by: Christopher Obbard <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

lambda.md : Add the lambda flow section #319

lambda.md : Add the lambda flow section #319

santoshmahto7 commented Jul 24, 2024

obbardc Jul 25, 2024

obbardc Jul 25, 2024

obbardc Jul 25, 2024

obbardc Jul 25, 2024

obbardc Jul 25, 2024

obbardc Jul 25, 2024

obbardc Jul 25, 2024

	Lambda uses github app [iocost-issue-creater](https://github.com/apps/iocost-issue-creater) to file a github issue, thus it's credentials information `App Id` and `Private Key` are stored in AWS parameter store.
	The Lambda function uses a GitHub app [iocost-issue-creater](https://github.com/apps/iocost-issue-creater) to file a GitGub issue, thus it's credentials information `App Id` and `Private Key` are stored in the AWS parameter store.

	- Then creates an issue in [iocost-benchmarks](https://github.com/iocost-benchmark/iocost-benchmarks) project using [iocost-issue-creater](https://github.com/apps/iocost-issue-creater) github app.
	- Then creates an issue in the [iocost-benchmarks](https://github.com/iocost-benchmark/iocost-benchmarks) project using [iocost-issue-creater](https://github.com/apps/iocost-issue-creater) GitHub app.

	- Issue contain a link to benchmark result stored in s3 bucket.
	- Issue contains a link to the benchmark result stored in an S3 bucket.


		### Lambda workflow:
		Client uploads the benchmark result (above steps) -> AWS Lambda runs -> save result to s3 bucket -> Create github Issue with link of result stored in s3.

	Client uploads the benchmark result (above steps) -> AWS Lambda runs -> save result to s3 bucket -> Create github Issue with link of result stored in s3.
	User uploads the benchmark result (following the above steps), the AWS Lambda function runs and saves the result into the S3 bucket, then the Lambda function creates a GitHub Issue with a link to the result stored in the S3 bucket.

	Thereafter it's job of [iocost-benchmarks project](https://github.com/iocost-benchmark/iocost-benchmarks) to import and merge the results with existing database and generate final hwdb file.
	The submitted result is further processed by the CI workflows running in the [iocost-benchmarks](https://github.com/iocost-benchmark/iocost-benchmarks/) repository, importing and merging the results with the existing database and finally generating the hwdb file.

lambda.md : Add the lambda flow section #319

Are you sure you want to change the base?

lambda.md : Add the lambda flow section #319

Conversation

santoshmahto7 commented Jul 24, 2024

obbardc Jul 25, 2024

Choose a reason for hiding this comment

obbardc Jul 25, 2024

Choose a reason for hiding this comment

obbardc Jul 25, 2024

Choose a reason for hiding this comment

obbardc Jul 25, 2024

Choose a reason for hiding this comment

obbardc Jul 25, 2024

Choose a reason for hiding this comment

obbardc Jul 25, 2024

Choose a reason for hiding this comment

obbardc Jul 25, 2024

Choose a reason for hiding this comment