Fix partition hashing #338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
irakliyk
reviewed
Oct 30, 2024
air/src/options.rs
Outdated
Comment on lines
378
to
380
| /// Returns the size of each partition used when committing to the main and auxiliary traces as | ||
| /// well as the constraint evaluation trace. | ||
| pub fn partition_size<E: FieldElement>(&self, num_columns: usize) -> usize { |
There was a problem hiding this comment.
Would be good to clarify in the comment that the returned number of columns is the number in the field E (rather than the base field of E).
irakliyk
approved these changes
Oct 30, 2024
|
I have now changed the base to |
irakliyk
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small fix for the condition under which partitioned hashing when committing is enabled.