Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for s-column as part of the support for LogUp-GKR #297

Merged
merged 58 commits into from
Sep 3, 2024
Merged

Add support for s-column as part of the support for LogUp-GKR #297

merged 58 commits into from
Sep 3, 2024

Conversation

Al-Kindi-0
Copy link
Contributor

Builds on #296

@Al-Kindi-0
feat: math utilities needed for sum-check protocol
29c033a
@Al-Kindi-0
feat: add sum-check prover and verifier
0d7fa67
@Al-Kindi-0
tests: add sanity tests for utils
6da91af
@Al-Kindi-0
feat: use SmallVec
0dfc229
@Al-Kindi-0
feat: add remaining functions for sum-check verifier
a51a464
@Al-Kindi-0
chore: move prover into sub-mod
581343d
@Al-Kindi-0
chore: remove utils mod
34807c9
@Al-Kindi-0
chore: move logup evaluator trait to separate file
e610411
@Al-Kindi-0
feat: add multi-threading support and simplify input sum-check
d98407a
@Al-Kindi-0
feat: add benchmarks and address feedback
3feaff8
@Al-Kindi-0
feat: address feedback and add benchmarks
0475b4e
@Al-Kindi-0
feat: add GKR backend for LogUp-GKR
9bfa423
@Al-Kindi-0
chore: remove old way of handling Lagrange kernel
3576e3f
@Al-Kindi-0
feat: simplify sum-check for input layer
d6f0bd4
@Al-Kindi-0
feat: add mult-threading to sum-checks and multi-linears
5dfed3d
@Al-Kindi-0
chore: unify serial and concurrent EQ impls
b62b31d
@Al-Kindi-0
fix: formatting
6a1cc1c
@Al-Kindi-0
fix: concurrent feature flag
70ea9d6
@Al-Kindi-0
feat: make query a mut ref in build_query
d49cdbb
@Al-Kindi-0
chore: update var names and simplify some structs
5f5b189
@Al-Kindi-0
chore: rebase
49f02a7
@Al-Kindi-0
chore: fix rebase against facebook:logup-gkr
64c5fde
@Al-Kindi-0
chore: address feedback
843b90d
@Al-Kindi-0
chore: add dummy GkrLogUp evaluator
229d9ed
@Al-Kindi-0
chore: fix clippy warnings
b36eaa3
@Al-Kindi-0
chore: address feedback
b8dcb35
@Al-Kindi-0
chore: loosen the trait bound
7f9e870
@Al-Kindi-0 Al-Kindi-0 marked this pull request as ready for review August 30, 2024 18:07
@Al-Kindi-0 Al-Kindi-0 changed the base branch from next to logup-gkr August 30, 2024 18:08
irakliyk
irakliyk reviewed Sep 2, 2024
View reviewed changes
Copy link
Collaborator

@irakliyk irakliyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you! I left some small comments inline.

air/src/air/context.rs Outdated Show resolved Hide resolved
air/src/air/logup_gkr.rs Outdated Show resolved Hide resolved
air/src/air/logup_gkr.rs Outdated Show resolved Hide resolved
prover/src/lib.rs Outdated Show resolved Hide resolved
prover/src/lib.rs Outdated Show resolved Hide resolved
prover/src/constraints/evaluator/logup_gkr.rs Outdated Show resolved Hide resolved
prover/src/constraints/evaluator/logup_gkr.rs Show resolved Hide resolved
prover/src/constraints/evaluator/logup_gkr.rs Outdated Show resolved Hide resolved
verifier/src/evaluator.rs Outdated Show resolved Hide resolved
verifier/src/evaluator.rs Outdated Show resolved Hide resolved
irakliyk
irakliyk approved these changes Sep 2, 2024
View reviewed changes
Copy link
Collaborator

@irakliyk irakliyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I left a few more small comments inline. After these are addressed, we can merge.

air/src/air/context.rs Outdated Show resolved Hide resolved
air/src/air/trace_info.rs Outdated Show resolved Hide resolved
verifier/src/evaluator.rs Outdated Show resolved Hide resolved
prover/src/constraints/evaluator/logup_gkr.rs Show resolved Hide resolved
prover/src/constraints/evaluator/logup_gkr.rs Outdated Show resolved Hide resolved
prover/src/constraints/evaluator/logup_gkr.rs Outdated Show resolved Hide resolved
@Al-Kindi-0 Al-Kindi-0 mentioned this pull request Sep 2, 2024
Closed
irakliyk
irakliyk approved these changes Sep 3, 2024
View reviewed changes
Copy link
Collaborator

@irakliyk irakliyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good! Thank you!

@irakliyk irakliyk merged commit ac9561d into facebook:logup-gkr Sep 3, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@irakliyk irakliyk irakliyk approved these changes

Assignees
No one assigned
Labels
cla signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Al-Kindi-0 @irakliyk @facebook-github-bot