Make dependence on number of openings explicit in security estimator #242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
irakliyk
reviewed
Jan 28, 2024
There was a problem hiding this comment.
Looks good! Thank you for updating this!
I think it would be good to add a test for get_proven_security() function at a few sample parameter sets. For example, we could use:base_field_bits = 64, collision_resistance = 128, trace_domain_size = 2^20, and then vary num_queries, blowup_factor, and extension_degree to get 96 bits or 128 bits of security.
These could be good "sanity checks" to make sure the numbers we are getting are as expected.
|
Added some tests for sanity checking things. Let me know if we need to add anything else. |
irakliyk
approved these changes
Jan 31, 2024
… use fix: rustfmt test: add sanity tests for proven security test: add test for 128 bits of security test: add 96 bits test and extension degree sanity test chore: minor nits
Al-Kindi-0
force-pushed
the
al-improv-fri-error
branch
from
4ea64bf
to
c7ed2fc
Compare
irakliyk
approved these changes
Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the title says and it corrects a few minor mistakes. The security estimates do not change (when rounding to bits) after testing with some of the examples.