Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement serialization and deserialization for usize type #238

Merged
merged 1 commit into from
Dec 29, 2023

Conversation

Fumuran
Copy link
Contributor

@Fumuran Fumuran commented Dec 21, 2023

This PR adds vint64 variable-length serialization and deserialization implementation for usize type.

@facebook-github-bot
Copy link

Hi @Overcastan!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

Copy link
Collaborator

@irakliyk irakliyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you! I left a few comments inline - the main one is about more error checking on decoding.

Also, is this the same format as what protobuf uses for variable integer encoding?

utils/core/src/serde/byte_writer.rs Outdated Show resolved Hide resolved
utils/core/src/serde/byte_reader.rs Outdated Show resolved Hide resolved
utils/core/src/tests.rs Show resolved Hide resolved
utils/core/src/serde/byte_writer.rs Outdated Show resolved Hide resolved
utils/core/Cargo.toml Outdated Show resolved Hide resolved
Copy link
Collaborator

@irakliyk irakliyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thank you! I left a couple of small comments inline. After these are addressed, let's squash the commits and merge.

utils/core/src/serde/byte_writer.rs Outdated Show resolved Hide resolved
utils/core/src/serde/byte_writer.rs Outdated Show resolved Hide resolved
@irakliyk irakliyk merged commit a450b81 into facebook:main Dec 29, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants