implement Ord for BaseElement
#225
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nashtare
reviewed
Oct 30, 2023
| @@ -52,7 +52,7 @@ const ELEMENT_BYTES: usize = core::mem::size_of::<u64>(); | |||
| /// | |||
| /// Internal values represent x * R mod M where R = 2^64 mod M and x in [0, M). | |||
| /// The backing type is `u64` but the internal values are always in the range [0, M). | |||
| #[derive(Copy, Clone, Debug, Default)] | |||
| #[derive(Copy, Clone, Debug, Default, Eq, PartialOrd, Ord)] | |||
There was a problem hiding this comment.
I think deriving PartialOrd directly relies on lexicographic ordering, which has little meaning when dealing with possibly unreduced elements or in Montgomery form?
There was a problem hiding this comment.
Do you have any recommendations on how to implement this properly, if at all possible?
There was a problem hiding this comment.
I would assume comparing reduced elements is the way to go (same as in implementations of PartialEq) though maybe @irakliyk has a different solution?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements
Ordfor allBaseElements. One benefit is that they can be used as the key to aBTreeMap(or any other data structure that requires ordering).