fix: fix jest timeout in cli cache tests #876
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed / motivation ?
In the refactor here #804 we should be wrapping
done()
in afinally
block to prevent the test from hanging if an error is thrown.Currently, if an assertion fails (e.g., an
expect()
check fails), the test times out instead of displaying the failure, sincedone()
is never called.With try/catch/finally:
done(err)
is called)This prevents Jest from hanging indefinitely and ensures failures are reported correctly
Testing
Tests pass on main.
In #875, tests no longer timeout, but accurately display the error:
Pre-flight checklist
Contribution Guidelines