fix: reflect */** prefix in rendered code/docs for args & kwargs

facebook · Mar 15, 2024 · eb11575 · eb11575
1 parent 40bba6d
commit eb11575
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 5 deletions.
diff --git a/starlark/src/docs/markdown.rs b/starlark/src/docs/markdown.rs
@@ -343,10 +343,10 @@ impl<'a> RenderMarkdown for TypeRenderer<'a> {
                         DocParam::NoArgs => "*".to_owned(),
                         DocParam::OnlyPosBefore => "/".to_owned(),
                         DocParam::Args { typ, name, .. } => {
-                            format!("{}{}", name, raw_type_prefix(": ", typ))
+                            format!("*{}{}", name, raw_type_prefix(": ", typ))
                         }
                         DocParam::Kwargs { typ, name, .. } => {
-                            format!("{}{}", name, raw_type_prefix(": ", typ))
+                            format!("**{}{}", name, raw_type_prefix(": ", typ))
                         }
                     });
 

diff --git a/starlark/src/docs/mod.rs b/starlark/src/docs/mod.rs
@@ -669,9 +669,13 @@ impl DocParam {
             },
             DocParam::NoArgs => "*".to_owned(),
             DocParam::OnlyPosBefore => "/".to_owned(),
-            DocParam::Args { name, typ, .. } | DocParam::Kwargs { name, typ, .. } => match typ {
-                t if t.is_any() => name.clone(),
-                typ => format!("{}: {}", name, typ),
+            DocParam::Args { name, typ, .. } => match typ {
+                t if t.is_any() => format!("*{}", name),
+                typ => format!("*{}: {}", name, typ),
+            },
+            DocParam::Kwargs { name, typ, .. } => match typ {
+                t if t.is_any() => format!("**{}", name),
+                typ => format!("**{}: {}", name, typ),
             },
         }
     }