Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1/n Adding Android support for Accessibility TtsSpan API - Support for accessibilitySpan and accessibilityLabel props in nested Text #35130
1/n Adding Android support for Accessibility TtsSpan API - Support for accessibilitySpan and accessibilityLabel props in nested Text #35130
Changes from 57 commits
216a30a
48a01d0
08d6f43
145303e
f66e914
3d4e662
1653d6b
6def7a9
7fa58f5
43e7c29
0afdc69
0cd0ac4
f5a3b49
08fc9ac
c2adbb8
46c4fb8
45ec47f
0a00193
72ee5a1
81fe302
7af9bd3
16f1f39
d845073
e215baa
03a125c
fe5c480
7e264da
d8823e5
9d4b8a5
7b85e25
aefa45f
95d6d3b
24c182a
7b4231f
4fbc54b
29a8104
e3fd7ff
3e1d292
8b23efd
bea5af9
6fc18d4
8b592f7
f2642f6
c4cd23b
576bad6
958ae95
8a59592
eb95e08
5aa9f74
cb52ad9
60ef8f0
06096d5
cc45e04
096019c
7f4a0cd
0a42fd0
79c4aed
dfc4063
3b30659
fe4e1e0
ef9c59b
ac79bae
145db13
a892b68
61e5920
f495025
753858e
821a4c8
4988339
02af5a4
dcb9f61
e7cbd28
565d7ed
a1c7e0f
f797c20
8b90011
e830578
25b212e
c058657
151b37c
6f68513
e1c56ac
ecc815b
7c80bdb
34ed14e
23241dd
112ed6f
235eda8
d536cf7
c154196
76ce49a
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you need to create this set each time setting an accessibility role? Maybe move this out as a static set if not needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ryancat I moved the Set to static with commit fabOnReact@3b30659 and commit fabOnReact@fe4e1e0