Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gap-support): updated Column and Row to set the gaps #1019

Closed
wants to merge 1 commit into from

Conversation

stevenkang90
Copy link
Contributor

  • updated LithoFlexLayoutDataProvider to set the gap against the node
  • updated LithoNode to check for gap and gapGutter
  • updated LithoYogaLayoutFunction to set gap and gapGutter

Summary

We deployed a version of litho internally to support gaps we're looking to update to v0.49.0 and want to fix gaps against master, This branch needs to be deployed and tested in our use case first. The draft is to request comments early

Changelog

Test Plan

   * updated LithoFlexLayoutDataProvider to set the gap against the node
   * updated LithoNode to check for gap and gapGutter
   * updated LithoYogaLayoutFunction to set gap and gapGutter
@facebook-github-bot
Copy link
Contributor

@astreet has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@astreet
Copy link
Contributor

astreet commented Oct 2, 2024

Thanks for the contribution! I made a couple updates around names before landing and added it to our Kotlin API.

@astreet
Copy link
Contributor

astreet commented Oct 2, 2024

If you have a chance, could you reach out to let us know how you/your organization use Litho? You can find my email if you search for my name in the git log for this repo! We're trying to evaluate how we want to engage with OSS and it'd be helpful to understand which other people/organizations are currently relying on it.

@facebook-github-bot
Copy link
Contributor

@astreet merged this pull request in 1d1002e.

@stevenkang90
Copy link
Contributor Author

If you have a chance, could you reach out to let us know how you/your organization use Litho? You can find my email if you search for my name in the git log for this repo! We're trying to evaluate how we want to engage with OSS and it'd be helpful to understand which other people/organizations are currently relying on it.

Hi I've tried to find your email in git, maybe its not on the publish master branch
git log | grep "Author: astreet" returns nothing

@astreet
Copy link
Contributor

astreet commented Oct 3, 2024

Try searching for andrews (or just emailing me at that name at meta.com)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants