Skip to content

Commit

Permalink
Remove createRow/Column from public API
Browse files Browse the repository at this point in the history
Summary: These shouldn't be public, and we also shouldn't re-define the default args.

Reviewed By: zielinskimz

Differential Revision: D63756866

fbshipit-source-id: af8bde0885ac92cae8d7aa28a576bd1cdd642942
  • Loading branch information
astreet authored and facebook-github-bot committed Oct 2, 2024
1 parent 1d1002e commit a7bbae1
Showing 1 changed file with 18 additions and 16 deletions.
34 changes: 18 additions & 16 deletions litho-core/src/main/java/com/facebook/litho/FlexboxContainer.kt
Original file line number Diff line number Diff line change
Expand Up @@ -61,14 +61,15 @@ inline fun ResourcesScope.Column(
createColumn(alignContent, alignItems, justifyContent, wrap, isReversed, gap, style, null)

/** Internal function to allow [Column] to be inlineable. */
fun ResourcesScope.createColumn(
alignContent: YogaAlign? = null,
alignItems: YogaAlign? = null,
justifyContent: YogaJustify? = null,
wrap: YogaWrap? = null,
isReversed: Boolean = false,
gap: Dimen? = null,
style: Style? = null,
@PublishedApi
internal fun ResourcesScope.createColumn(
alignContent: YogaAlign?,
alignItems: YogaAlign?,
justifyContent: YogaJustify?,
wrap: YogaWrap?,
isReversed: Boolean,
gap: Dimen?,
style: Style?,
resolvedContainerScope: FlexboxContainerScope?
): Column =
Column(
Expand Down Expand Up @@ -123,14 +124,15 @@ inline fun ResourcesScope.Row(
): Row = createRow(alignContent, alignItems, justifyContent, wrap, isReversed, gap, style, null)

/** Internal function to allow [Row] to be inlineable. */
fun ResourcesScope.createRow(
alignContent: YogaAlign? = null,
alignItems: YogaAlign? = null,
justifyContent: YogaJustify? = null,
wrap: YogaWrap? = null,
isReversed: Boolean = false,
gap: Dimen? = null,
style: Style? = null,
@PublishedApi
internal fun ResourcesScope.createRow(
alignContent: YogaAlign?,
alignItems: YogaAlign?,
justifyContent: YogaJustify?,
wrap: YogaWrap?,
isReversed: Boolean,
gap: Dimen?,
style: Style?,
resolvedContainerScope: FlexboxContainerScope?
): Row =
Row(
Expand Down

0 comments on commit a7bbae1

Please sign in to comment.