Skip to content

Commit

Permalink
Second attmpt [ABT2] Using new kotlin-compiler-embeddable and related…
Browse files Browse the repository at this point in the history
… artifacts in a toolchain"

Summary:
## This stack
1. Unifies Kotlin compiler Meta Kotlin builds on `kotlin-compiler-embeddable`
2. Limits the usage of `kotlin-compiler` across the codebase
3. Removes -shaded -unshaded artifact flavours codebase-wide

## This diff

changes kotlin-compiler to kotlin-compiler-embeddable, also fixes related problems across the stack (-shaded artifacts, embeddable serialization, parcelize, etc)

allow-large-files

Reviewed By: lty1308

Differential Revision: D64856423

fbshipit-source-id: ad4243894b0289db1e7997e6bd573777fb9706d5
  • Loading branch information
rybalkinsd authored and facebook-github-bot committed Oct 24, 2024
1 parent 685ae56 commit 58d4a9c
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions litho-compiler-plugin/compiler/BUCK
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ feature_native.kotlin_library(
feature = FBApp_UIFrameworks_Litho_Litho,
labels = [],
provided_deps = [
"//third-party/kotlin:kotlin-compiler",
"//third-party/kotlin:kotlin-compiler-embeddable",
],
resources = glob(["resources/**"]),
resources_root = "resources",
Expand All @@ -38,7 +38,7 @@ fb_kotlin_test(
"//fbandroid/third-party/java/assertj:assertj-core",
"//fbandroid/third-party/java/junit:junit",
"//third-party/kotlin:kotlin",
"//third-party/kotlin:kotlin-compiler",
"//third-party/kotlin:kotlin-compiler-embeddable",
"//third-party/kotlin:kotlin-reflect",
"//third-party/kotlin/kotlin-compile-testing:kotlin-compile-testing",
"//third-party/kotlin/mockito-kotlin2:mockito-kotlin2",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,9 @@

package com.facebook.litho

import com.intellij.openapi.project.Project
import org.jetbrains.kotlin.analyzer.AnalysisResult
import org.jetbrains.kotlin.cli.common.messages.CompilerMessageSourceLocation
import org.jetbrains.kotlin.com.intellij.openapi.project.Project
import org.jetbrains.kotlin.descriptors.ModuleDescriptor
import org.jetbrains.kotlin.psi.KtFile
import org.jetbrains.kotlin.resolve.BindingTrace
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,9 @@

package com.facebook.litho

import com.intellij.psi.PsiElement
import org.jetbrains.kotlin.cli.common.messages.CompilerMessageLocation
import org.jetbrains.kotlin.cli.common.messages.CompilerMessageSourceLocation
import org.jetbrains.kotlin.com.intellij.psi.PsiElement
import org.jetbrains.kotlin.diagnostics.PsiDiagnosticUtils
import org.jetbrains.kotlin.psi.KtCallExpression
import org.jetbrains.kotlin.psi.KtElement
Expand Down

0 comments on commit 58d4a9c

Please sign in to comment.