- Add conversion of the iterator from Flow to TS #1604
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D68776171 |
|
@coado is there a reason to export these to GitHub before they land? |
Maybe(?) no good reason in the Hermes repo, but for context we enforce export before land in RN to ensure changes don't break OSS CI - exporting triggers GH CI to be reported as diff signals. |
Summary: `@iterator` and `@asyncIterator` are valid syntaxes for Flow but not for TS which accepts [Symbol.iterator] and [Symbol.asyncIterator]. According to flow lexer these are the only valid syntaxes in this form so checking for other cases prefixed with `@@` should not be required. Changelog: [flow-api-translator] - Added conversion of the iterator from Flow to TS Differential Revision: D68776171
coado
force-pushed
the
export-D68776171
branch
from
d0de615 to
68d2102
Compare
|
This pull request was exported from Phabricator. Differential Revision: D68776171 |
|
This pull request has been merged in ede7def. |
My bad, I thought that there is the same procedure with exporting to GH as with react-native. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Feb 3, 2025
Summary: Original Author: [email protected] Original Git: ede7def Original Reviewed By: pieterv Original Revision: D68776171 Pull Request resolved: #1604 `iterator` and `asyncIterator` are valid syntaxes for Flow but not for TS which accepts [Symbol.iterator] and [Symbol.asyncIterator]. According to flow lexer these are the only valid syntaxes in this form so checking for other cases prefixed with `@@` should not be required. Changelog: [flow-api-translator] - Added conversion of the iterator and asyncIterator from Flow to TS Reviewed By: fbmal7 Differential Revision: D69061638 fbshipit-source-id: 5ac46bca3fa1d8b08297bc3e26d9124e06c533f4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
@iteratorand@asyncIteratorare valid syntaxes for Flow but not for TS which accepts [Symbol.iterator] and [Symbol.asyncIterator]. According to flow lexer these are the only valid syntaxes in this form so checking for other cases prefixed with@@should not be required.Changelog:
[flow-api-translator] - Added conversion of the iterator from Flow to TS
Differential Revision: D68776171