Create a modular CMake configuration #205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add configuration options to disable creation of extra binaries: tests, checks, benchmark... Those options are controlled by -DNO_XXX=1. The dependencies required by each target are discovered from the CMakeLists.txt file defining the target itself, so disabling part of the project will ensure the dependencies for this part are not fetched.
Create an `integration` target to build both iptables and nftables.
Define custom command to generate the parser and the lexer used by bfcli so `make check` can depends on the output of those commands, instead of depending on `make bfcli`.
qdeslandes
force-pushed
the
modular_cmake
branch
from
178c4ac to
240c5f7
Compare
The CI build step runs on all of the supported distributions. However, the benchmark currently doesn't support Fedora 39 (bpf_prog_get_info_by_fd() doesn't exists there). This change disable the benchmark build for the build step of the CI (the benchmark will run for Fedora 41 anyway).
qdeslandes
force-pushed
the
modular_cmake
branch
from
240c5f7 to
782494e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modify the configuration generator to allow parts of the project to be disabled. This will simplify the packaging of
bpfilteras it will reduce the number of dependencies required to only build and test the project.By default, the whole project is configured, but some of it can be disabled using
-DNO_XXX=1.Additionally:
integrationtarget to build bothiptablesandnftablesjqby filtering thecompile_commands.jsonfile using a custom Python scriptmake checkcan depend on them, instead of depending on thebfclitarget