Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Variable Names for P100(Max) Latency in Cachebench #368

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

SuhoSon
Copy link

@SuhoSon SuhoSon commented Jan 7, 2025

Issue

== Test Results ==
== Allocator Stats ==
...
NVM Read  Latency    p999999  :     10000.00 us
NVM Read  Latency    p100      :    0.00 us
...
NVM Write Latency    p999999  :     10000.00 us
NVM Write Latency    p100      :     0.00 us
...

Debug

Cachelib is using variable name for p100 as max (cachelib/common/PercentileStats.cpp:72). But, Cachebench was using variable name for p100 as p100. So, I have changed Cachebench's variable name to max.

Result

== Test Results ==
== Allocator Stats ==
...
NVM Read  Latency    p999999  :     10000.00 us
NVM Read  Latency    max      :    20000.00 us
...
NVM Write Latency    p999999  :     10000.00 us
NVM Write Latency    max      :     20000.00 us
...

This commit fixes a bug where the P100 Latency is not displayed in the output of Cachebench. The cause of the bug was due to different variable names used for P100 Latency in Cachelib and Cachebench, and the variable name in Cachebench has been modified to match the variable name used in Cachelib.
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants