Remove multi-surrogate support in MBM #2957
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D64875988 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2957 +/- ##
=======================================
Coverage 95.68% 95.68%
=======================================
Files 504 504
Lines 49531 49433 -98
=======================================
- Hits 47395 47302 -93
+ Misses 2136 2131 -5 ☔ View full report in Codecov by Sentry. |
Summary: MBM with multiple surrogates was never supported e2e and is being deprecated. This diff: - Adds a new `surrogate_spec: Surrogate` input to `BoTorchModel`, to replace `surrogate_specs: dict[str, Surrogate]` input. - Raises a `DeprecationWarning` (as an exception) if `surrogate_specs` is passed in with multiple elements. - Cleans up the code that was necessary to support multiple surrogates. Differential Revision: D64875988
saitcakmak
force-pushed
the
export-D64875988
branch
from
5ca9a59
to
9dcfef4
Compare
|
This pull request was exported from Phabricator. Differential Revision: D64875988 |
saitcakmak
added a commit
to saitcakmak/Ax
that referenced
this pull request
Oct 24, 2024
Summary: MBM with multiple surrogates was never supported e2e and is being deprecated. This diff: - Adds a new `surrogate_spec: Surrogate` input to `BoTorchModel`, to replace `surrogate_specs: dict[str, Surrogate]` input. - Raises a `DeprecationWarning` (as an exception) if `surrogate_specs` is passed in with multiple elements. - Cleans up the code that was necessary to support multiple surrogates. Differential Revision: D64875988
saitcakmak
added a commit
to saitcakmak/Ax
that referenced
this pull request
Oct 24, 2024
Summary: MBM with multiple surrogates was never supported e2e and is being deprecated. This diff: - Adds a new `surrogate_spec: Surrogate` input to `BoTorchModel`, to replace `surrogate_specs: dict[str, Surrogate]` input. - Raises a `DeprecationWarning` (as an exception) if `surrogate_specs` is passed in with multiple elements. - Cleans up the code that was necessary to support multiple surrogates. Differential Revision: D64875988
|
This pull request has been merged in 3033b14. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
MBM with multiple surrogates was never supported e2e and is being deprecated. This diff:
surrogate_spec: Surrogateinput toBoTorchModel, to replacesurrogate_specs: dict[str, Surrogate]input.DeprecationWarning(as an exception) ifsurrogate_specsis passed in with multiple elements.Differential Revision: D64875988