Redo constraint violation indicators and legend on inample and predicted plots #2955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D64850289 |
danielcohenlive
pushed a commit
to danielcohenlive/Ax-1
that referenced
this pull request
Oct 24, 2024
…cted plots (facebook#2955) Summary: Instead of varying sizing, we're adding a red outline of varying opacity based on the overall probability of constraint violation. There is a hack to make sure the outlines don't appear in the legend, as the legend normally reflects the first point in each group. We're hiding the original and creating a duplicate group of the same name at point (None, None). In doing this, we give up the ability to toggle points on and off the graph by clicking on their legend item, which I just discovered existed. {F1944580069} Differential Revision: D64850289
danielcohenlive
force-pushed
the
export-D64850289
branch
from
c0ccf7b
to
ffe329b
Compare
|
This pull request was exported from Phabricator. Differential Revision: D64850289 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2955 +/- ##
=======================================
Coverage 95.68% 95.68%
=======================================
Files 504 504
Lines 49547 49559 +12
=======================================
+ Hits 47411 47423 +12
Misses 2136 2136 ☔ View full report in Codecov by Sentry. |
…cted plots (facebook#2955) Summary: Instead of varying sizing, we're adding a red outline of varying opacity based on the overall probability of constraint violation. There is a hack to make sure the outlines don't appear in the legend, as the legend normally reflects the first point in each group. We're hiding the original and creating a duplicate group of the same name at point (None, None). In doing this, we give up the ability to toggle points on and off the graph by clicking on their legend item, which I just discovered existed. {F1944580069} Reviewed By: ItsMrLin Differential Revision: D64850289
danielcohenlive
pushed a commit
to danielcohenlive/Ax-1
that referenced
this pull request
Oct 25, 2024
…cted plots (facebook#2955) Summary: Instead of varying sizing, we're adding a red outline of varying opacity based on the overall probability of constraint violation. There is a hack to make sure the outlines don't appear in the legend, as the legend normally reflects the first point in each group. We're hiding the original and creating a duplicate group of the same name at point (None, None). In doing this, we give up the ability to toggle points on and off the graph by clicking on their legend item, which I just discovered existed. {F1944580069} Reviewed By: ItsMrLin Differential Revision: D64850289
danielcohenlive
force-pushed
the
export-D64850289
branch
2 times, most recently
from
5f1c669
to
59237ad
Compare
|
This pull request was exported from Phabricator. Differential Revision: D64850289 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D64850289 |
|
This pull request has been merged in f6bf492. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Instead of varying sizing, we're adding a red outline of varying opacity based on the overall probability of constraint violation.
There is a hack to make sure the outlines don't appear in the legend, as the legend normally reflects the first point in each group. We're hiding the original and creating a duplicate group of the same name at point (None, None). In doing this, we give up the ability to toggle points on and off the graph by clicking on their legend item, which I just discovered existed.
{F1944580069}
Differential Revision: D64850289