Make BoTorch test problems into ParamBasedTestProblems #2944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D63639190 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2944 +/- ##
=======================================
Coverage 95.68% 95.68%
=======================================
Files 504 504
Lines 49533 49547 +14
=======================================
+ Hits 47395 47411 +16
+ Misses 2138 2136 -2 ☔ View full report in Codecov by Sentry. |
esantorella
added a commit
to esantorella/Ax
that referenced
this pull request
Oct 23, 2024
Summary: Context: In the benchmarks, we currently have a zoo of five runners designed to handle different ways of generating data. This will make it challenging to support other changes to runners, such as running trials asynchronously. This diff is a step towards consolidating into one Runner, abstracting away the data-generating process into a test problem. * BoTorchTestProblemRunner has a BoTorch problem * ParamBasedTestProblemRunner has a ParamBasedTestProblem * SurrogateRunner has a SurrogateProblem * `BoTorchTestProblemRunner` and `ParamBasedTestProblemRunner` subclass `BenchmarkRunner` * `SurrogateRunner` subclasses `BenchmarkRunner` This diff will enable going from 5 runners to 3, wrapping BoTorch problems with `ParamBasedTestProblem`. This will allow for combining `BoTorchTestProblemRunner`, `ParamBasedTestProblemRunner`, and `SyntheticProblemRunner`. This PR: * Introduces `BoTorchTestProblem`, which is a `ParamBasedTestProblem` and thus can be used with `ParamBasedTestProblemRunner`. It localizes tensor-related logic, including `modified_bounds`, into the BoTorch problem so it doesn't need to be handled by the runner. * Gets rid of `SyntheticProblemRunner`, merging it with `ParamBasedTestProblemRunner`. We may want to rename this class after more consolidation. * Makes `BoTorchTestProblemRunner` a do-nothing subclass of `ParamBasedTestProblemRunner` Differential Revision: D63639190
esantorella
added a commit
to esantorella/Ax
that referenced
this pull request
Oct 23, 2024
Summary: Context: In the benchmarks, we currently have a zoo of five runners designed to handle different ways of generating data. This will make it challenging to support other changes to runners, such as running trials asynchronously. This diff is a step towards consolidating into one Runner, abstracting away the data-generating process into a test problem. * BoTorchTestProblemRunner has a BoTorch problem * ParamBasedTestProblemRunner has a ParamBasedTestProblem * SurrogateRunner has a SurrogateProblem * `BoTorchTestProblemRunner` and `ParamBasedTestProblemRunner` subclass `BenchmarkRunner` * `SurrogateRunner` subclasses `BenchmarkRunner` This diff will enable going from 5 runners to 3, wrapping BoTorch problems with `ParamBasedTestProblem`. This will allow for combining `BoTorchTestProblemRunner`, `ParamBasedTestProblemRunner`, and `SyntheticProblemRunner`. This PR: * Introduces `BoTorchTestProblem`, which is a `ParamBasedTestProblem` and thus can be used with `ParamBasedTestProblemRunner`. It localizes tensor-related logic, including `modified_bounds`, into the BoTorch problem so it doesn't need to be handled by the runner. * Gets rid of `SyntheticProblemRunner`, merging it with `ParamBasedTestProblemRunner`. We may want to rename this class after more consolidation. * Makes `BoTorchTestProblemRunner` a do-nothing subclass of `ParamBasedTestProblemRunner` Differential Revision: D63639190
esantorella
force-pushed
the
export-D63639190
branch
from
afe1ad4
to
fd4ae44
Compare
|
This pull request was exported from Phabricator. Differential Revision: D63639190 |
esantorella
added a commit
to esantorella/Ax
that referenced
this pull request
Oct 23, 2024
Summary: Context: In the benchmarks, we currently have a zoo of five runners designed to handle different ways of generating data. This will make it challenging to support other changes to runners, such as running trials asynchronously. This diff is a step towards consolidating into one Runner, abstracting away the data-generating process into a test problem. * BoTorchTestProblemRunner has a BoTorch problem * ParamBasedTestProblemRunner has a ParamBasedTestProblem * SurrogateRunner has a SurrogateProblem * `BoTorchTestProblemRunner` and `ParamBasedTestProblemRunner` subclass `BenchmarkRunner` * `SurrogateRunner` subclasses `BenchmarkRunner` This diff will enable going from 5 runners to 3, wrapping BoTorch problems with `ParamBasedTestProblem`. This will allow for combining `BoTorchTestProblemRunner`, `ParamBasedTestProblemRunner`, and `SyntheticProblemRunner`. This PR: * Introduces `BoTorchTestProblem`, which is a `ParamBasedTestProblem` and thus can be used with `ParamBasedTestProblemRunner`. It localizes tensor-related logic, including `modified_bounds`, into the BoTorch problem so it doesn't need to be handled by the runner. * Gets rid of `SyntheticProblemRunner`, merging it with `ParamBasedTestProblemRunner`. We may want to rename this class after more consolidation. * Makes `BoTorchTestProblemRunner` a do-nothing subclass of `ParamBasedTestProblemRunner` Differential Revision: D63639190
esantorella
force-pushed
the
export-D63639190
branch
from
fd4ae44
to
62cde69
Compare
|
This pull request was exported from Phabricator. Differential Revision: D63639190 |
esantorella
added a commit
to esantorella/Ax
that referenced
this pull request
Oct 23, 2024
Summary: Context: In the benchmarks, we currently have a zoo of five runners designed to handle different ways of generating data. This will make it challenging to support other changes to runners, such as running trials asynchronously. This diff is a step towards consolidating into one Runner, abstracting away the data-generating process into a test problem. * BoTorchTestProblemRunner has a BoTorch problem * ParamBasedTestProblemRunner has a ParamBasedTestProblem * SurrogateRunner has a SurrogateProblem * `BoTorchTestProblemRunner` and `ParamBasedTestProblemRunner` subclass `BenchmarkRunner` * `SurrogateRunner` subclasses `BenchmarkRunner` This diff will enable going from 5 runners to 3, wrapping BoTorch problems with `ParamBasedTestProblem`. This will allow for combining `BoTorchTestProblemRunner`, `ParamBasedTestProblemRunner`, and `SyntheticProblemRunner`. This PR: * Introduces `BoTorchTestProblem`, which is a `ParamBasedTestProblem` and thus can be used with `ParamBasedTestProblemRunner`. It localizes tensor-related logic, including `modified_bounds`, into the BoTorch problem so it doesn't need to be handled by the runner. * Gets rid of `SyntheticProblemRunner`, merging it with `ParamBasedTestProblemRunner`. We may want to rename this class after more consolidation. * Makes `BoTorchTestProblemRunner` a do-nothing subclass of `ParamBasedTestProblemRunner` Reviewed By: Balandat Differential Revision: D63639190
esantorella
force-pushed
the
export-D63639190
branch
from
62cde69
to
bf7b0b0
Compare
|
This pull request was exported from Phabricator. Differential Revision: D63639190 |
esantorella
force-pushed
the
export-D63639190
branch
from
bf7b0b0
to
57ed1a9
Compare
esantorella
added a commit
to esantorella/Ax
that referenced
this pull request
Oct 24, 2024
Summary: Context: In the benchmarks, we currently have a zoo of five runners designed to handle different ways of generating data. This will make it challenging to support other changes to runners, such as running trials asynchronously. This diff is a step towards consolidating into one Runner, abstracting away the data-generating process into a test problem. * BoTorchTestProblemRunner has a BoTorch problem * ParamBasedTestProblemRunner has a ParamBasedTestProblem * SurrogateRunner has a SurrogateProblem * `BoTorchTestProblemRunner` and `ParamBasedTestProblemRunner` subclass `BenchmarkRunner` * `SurrogateRunner` subclasses `BenchmarkRunner` This diff will enable going from 5 runners to 3, wrapping BoTorch problems with `ParamBasedTestProblem`. This will allow for combining `BoTorchTestProblemRunner`, `ParamBasedTestProblemRunner`, and `SyntheticProblemRunner`. This PR: * Introduces `BoTorchTestProblem`, which is a `ParamBasedTestProblem` and thus can be used with `ParamBasedTestProblemRunner`. It localizes tensor-related logic, including `modified_bounds`, into the BoTorch problem so it doesn't need to be handled by the runner. * Gets rid of `SyntheticProblemRunner`, merging it with `ParamBasedTestProblemRunner`. We may want to rename this class after more consolidation. * Makes `BoTorchTestProblemRunner` a do-nothing subclass of `ParamBasedTestProblemRunner` Reviewed By: Balandat Differential Revision: D63639190
|
This pull request was exported from Phabricator. Differential Revision: D63639190 |
esantorella
added a commit
to esantorella/Ax
that referenced
this pull request
Oct 24, 2024
Summary: Context: In the benchmarks, we currently have a zoo of five runners designed to handle different ways of generating data. This will make it challenging to support other changes to runners, such as running trials asynchronously. This diff is a step towards consolidating into one Runner, abstracting away the data-generating process into a test problem. * BoTorchTestProblemRunner has a BoTorch problem * ParamBasedTestProblemRunner has a ParamBasedTestProblem * SurrogateRunner has a SurrogateProblem * `BoTorchTestProblemRunner` and `ParamBasedTestProblemRunner` subclass `BenchmarkRunner` * `SurrogateRunner` subclasses `BenchmarkRunner` This diff will enable going from 5 runners to 3, wrapping BoTorch problems with `ParamBasedTestProblem`. This will allow for combining `BoTorchTestProblemRunner`, `ParamBasedTestProblemRunner`, and `SyntheticProblemRunner`. This PR: * Introduces `BoTorchTestProblem`, which is a `ParamBasedTestProblem` and thus can be used with `ParamBasedTestProblemRunner`. It localizes tensor-related logic, including `modified_bounds`, into the BoTorch problem so it doesn't need to be handled by the runner. * Gets rid of `SyntheticProblemRunner`, merging it with `ParamBasedTestProblemRunner`. We may want to rename this class after more consolidation. * Makes `BoTorchTestProblemRunner` a do-nothing subclass of `ParamBasedTestProblemRunner` Reviewed By: Balandat Differential Revision: D63639190
Summary: Context: In the benchmarks, we currently have a zoo of five runners designed to handle different ways of generating data. This will make it challenging to support other changes to runners, such as running trials asynchronously. This diff is a step towards consolidating into one Runner, abstracting away the data-generating process into a test problem. * BoTorchTestProblemRunner has a BoTorch problem * ParamBasedTestProblemRunner has a ParamBasedTestProblem * SurrogateRunner has a SurrogateProblem * `BoTorchTestProblemRunner` and `ParamBasedTestProblemRunner` subclass `BenchmarkRunner` * `SurrogateRunner` subclasses `BenchmarkRunner` This diff will enable going from 5 runners to 3, wrapping BoTorch problems with `ParamBasedTestProblem`. This will allow for combining `BoTorchTestProblemRunner`, `ParamBasedTestProblemRunner`, and `SyntheticProblemRunner`. This PR: * Introduces `BoTorchTestProblem`, which is a `ParamBasedTestProblem` and thus can be used with `ParamBasedTestProblemRunner`. It localizes tensor-related logic, including `modified_bounds`, into the BoTorch problem so it doesn't need to be handled by the runner. * Gets rid of `SyntheticProblemRunner`, merging it with `ParamBasedTestProblemRunner`. We may want to rename this class after more consolidation. * Makes `BoTorchTestProblemRunner` a do-nothing subclass of `ParamBasedTestProblemRunner` Reviewed By: Balandat Differential Revision: D63639190
esantorella
added a commit
to esantorella/Ax
that referenced
this pull request
Oct 24, 2024
Summary: Context: In the benchmarks, we currently have a zoo of five runners designed to handle different ways of generating data. This will make it challenging to support other changes to runners, such as running trials asynchronously. This diff is a step towards consolidating into one Runner, abstracting away the data-generating process into a test problem. * BoTorchTestProblemRunner has a BoTorch problem * ParamBasedTestProblemRunner has a ParamBasedTestProblem * SurrogateRunner has a SurrogateProblem * `BoTorchTestProblemRunner` and `ParamBasedTestProblemRunner` subclass `BenchmarkRunner` * `SurrogateRunner` subclasses `BenchmarkRunner` This diff will enable going from 5 runners to 3, wrapping BoTorch problems with `ParamBasedTestProblem`. This will allow for combining `BoTorchTestProblemRunner`, `ParamBasedTestProblemRunner`, and `SyntheticProblemRunner`. This PR: * Introduces `BoTorchTestProblem`, which is a `ParamBasedTestProblem` and thus can be used with `ParamBasedTestProblemRunner`. It localizes tensor-related logic, including `modified_bounds`, into the BoTorch problem so it doesn't need to be handled by the runner. * Gets rid of `SyntheticProblemRunner`, merging it with `ParamBasedTestProblemRunner`. We may want to rename this class after more consolidation. * Makes `BoTorchTestProblemRunner` a do-nothing subclass of `ParamBasedTestProblemRunner` Reviewed By: Balandat Differential Revision: D63639190
esantorella
force-pushed
the
export-D63639190
branch
from
57ed1a9
to
b501d0c
Compare
|
This pull request was exported from Phabricator. Differential Revision: D63639190 |
esantorella
added a commit
to esantorella/Ax
that referenced
this pull request
Oct 24, 2024
Summary: Context: In the benchmarks, we currently have a zoo of five runners designed to handle different ways of generating data. This will make it challenging to support other changes to runners, such as running trials asynchronously. This diff is a step towards consolidating into one Runner, abstracting away the data-generating process into a test problem. * BoTorchTestProblemRunner has a BoTorch problem * ParamBasedTestProblemRunner has a ParamBasedTestProblem * SurrogateRunner has a SurrogateProblem * `BoTorchTestProblemRunner` and `ParamBasedTestProblemRunner` subclass `BenchmarkRunner` * `SurrogateRunner` subclasses `BenchmarkRunner` This diff will enable going from 5 runners to 3, wrapping BoTorch problems with `ParamBasedTestProblem`. This will allow for combining `BoTorchTestProblemRunner`, `ParamBasedTestProblemRunner`, and `SyntheticProblemRunner`. This PR: * Introduces `BoTorchTestProblem`, which is a `ParamBasedTestProblem` and thus can be used with `ParamBasedTestProblemRunner`. It localizes tensor-related logic, including `modified_bounds`, into the BoTorch problem so it doesn't need to be handled by the runner. * Gets rid of `SyntheticProblemRunner`, merging it with `ParamBasedTestProblemRunner`. We may want to rename this class after more consolidation. * Makes `BoTorchTestProblemRunner` a do-nothing subclass of `ParamBasedTestProblemRunner` Reviewed By: Balandat Differential Revision: D63639190
esantorella
added a commit
to esantorella/Ax
that referenced
this pull request
Oct 24, 2024
Summary: Context: In the benchmarks, we currently have a zoo of five runners designed to handle different ways of generating data. This will make it challenging to support other changes to runners, such as running trials asynchronously. This diff is a step towards consolidating into one Runner, abstracting away the data-generating process into a test problem. * BoTorchTestProblemRunner has a BoTorch problem * ParamBasedTestProblemRunner has a ParamBasedTestProblem * SurrogateRunner has a SurrogateProblem * `BoTorchTestProblemRunner` and `ParamBasedTestProblemRunner` subclass `BenchmarkRunner` * `SurrogateRunner` subclasses `BenchmarkRunner` This diff will enable going from 5 runners to 3, wrapping BoTorch problems with `ParamBasedTestProblem`. This will allow for combining `BoTorchTestProblemRunner`, `ParamBasedTestProblemRunner`, and `SyntheticProblemRunner`. This PR: * Introduces `BoTorchTestProblem`, which is a `ParamBasedTestProblem` and thus can be used with `ParamBasedTestProblemRunner`. It localizes tensor-related logic, including `modified_bounds`, into the BoTorch problem so it doesn't need to be handled by the runner. * Gets rid of `SyntheticProblemRunner`, merging it with `ParamBasedTestProblemRunner`. We may want to rename this class after more consolidation. * Makes `BoTorchTestProblemRunner` a do-nothing subclass of `ParamBasedTestProblemRunner` Reviewed By: Balandat Differential Revision: D63639190
esantorella
added a commit
to esantorella/Ax
that referenced
this pull request
Oct 24, 2024
Summary: Context: In the benchmarks, we currently have a zoo of five runners designed to handle different ways of generating data. This will make it challenging to support other changes to runners, such as running trials asynchronously. This diff is a step towards consolidating into one Runner, abstracting away the data-generating process into a test problem. * BoTorchTestProblemRunner has a BoTorch problem * ParamBasedTestProblemRunner has a ParamBasedTestProblem * SurrogateRunner has a SurrogateProblem * `BoTorchTestProblemRunner` and `ParamBasedTestProblemRunner` subclass `BenchmarkRunner` * `SurrogateRunner` subclasses `BenchmarkRunner` This diff will enable going from 5 runners to 3, wrapping BoTorch problems with `ParamBasedTestProblem`. This will allow for combining `BoTorchTestProblemRunner`, `ParamBasedTestProblemRunner`, and `SyntheticProblemRunner`. This PR: * Introduces `BoTorchTestProblem`, which is a `ParamBasedTestProblem` and thus can be used with `ParamBasedTestProblemRunner`. It localizes tensor-related logic, including `modified_bounds`, into the BoTorch problem so it doesn't need to be handled by the runner. * Gets rid of `SyntheticProblemRunner`, merging it with `ParamBasedTestProblemRunner`. We may want to rename this class after more consolidation. * Makes `BoTorchTestProblemRunner` a do-nothing subclass of `ParamBasedTestProblemRunner` Reviewed By: Balandat Differential Revision: D63639190
esantorella
added a commit
to esantorella/Ax
that referenced
this pull request
Oct 24, 2024
Summary: Pull Request resolved: facebook#2944 Context: In the benchmarks, we currently have a zoo of five runners designed to handle different ways of generating data. This will make it challenging to support other changes to runners, such as running trials asynchronously. This diff is a step towards consolidating into one Runner, abstracting away the data-generating process into a test problem. * BoTorchTestProblemRunner has a BoTorch problem * ParamBasedTestProblemRunner has a ParamBasedTestProblem * SurrogateRunner has a SurrogateProblem * `BoTorchTestProblemRunner` and `ParamBasedTestProblemRunner` subclass `BenchmarkRunner` * `SurrogateRunner` subclasses `BenchmarkRunner` This diff will enable going from 5 runners to 3, wrapping BoTorch problems with `ParamBasedTestProblem`. This will allow for combining `BoTorchTestProblemRunner`, `ParamBasedTestProblemRunner`, and `SyntheticProblemRunner`. This PR: * Introduces `BoTorchTestProblem`, which is a `ParamBasedTestProblem` and thus can be used with `ParamBasedTestProblemRunner`. It localizes tensor-related logic, including `modified_bounds`, into the BoTorch problem so it doesn't need to be handled by the runner. * Gets rid of `SyntheticProblemRunner`, merging it with `ParamBasedTestProblemRunner`. We may want to rename this class after more consolidation. * Makes `BoTorchTestProblemRunner` a do-nothing subclass of `ParamBasedTestProblemRunner` Differential Revision: D63639190 Reviewed By: Balandat
|
This pull request has been merged in 8dcb808. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Context:
In the benchmarks, we currently have a zoo of five runners designed to handle different ways of generating data. This will make it challenging to support other changes to runners, such as running trials asynchronously. This diff is a step towards consolidating into one Runner, abstracting away the data-generating process into a test problem.
BoTorchTestProblemRunnerandParamBasedTestProblemRunnersubclassBenchmarkRunnerSurrogateRunnersubclassesBenchmarkRunnerThis diff will enable going from 5 runners to 3, wrapping BoTorch problems with
ParamBasedTestProblem. This will allow for combiningBoTorchTestProblemRunner,ParamBasedTestProblemRunner, andSyntheticProblemRunner.This PR:
BoTorchTestProblem, which is aParamBasedTestProblemand thus can be used withParamBasedTestProblemRunner. It localizes tensor-related logic, includingmodified_bounds, into the BoTorch problem so it doesn't need to be handled by the runner.SyntheticProblemRunner, merging it withParamBasedTestProblemRunner. We may want to rename this class after more consolidation.BoTorchTestProblemRunnera do-nothing subclass ofParamBasedTestProblemRunnerDifferential Revision: D63639190