Undo pep585_imports in test_kwargutils #2672
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D61480862 |
mpolson64
added a commit
to mpolson64/Ax
that referenced
this pull request
Aug 19, 2024
Summary: Pull Request resolved: facebook#2672 For whatever reason validate_kwarg_typing does not play well with this change ONLY IN GITHUB ACTIONS. **Tests pass internally with or without this change.** Reviewed By: esantorella Differential Revision: D61480862
mpolson64
force-pushed
the
export-D61480862
branch
from
f773911
to
fa1a19f
Compare
|
This pull request was exported from Phabricator. Differential Revision: D61480862 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D61480862 |
mpolson64
added a commit
to mpolson64/Ax
that referenced
this pull request
Aug 19, 2024
Summary: Pull Request resolved: facebook#2672 For whatever reason validate_kwarg_typing does not play well with this change ONLY IN GITHUB ACTIONS. **Tests pass internally with or without this change.** Reviewed By: esantorella Differential Revision: D61480862
mpolson64
force-pushed
the
export-D61480862
branch
from
fa1a19f
to
a0e8a2e
Compare
Summary: Pull Request resolved: facebook#2672 For whatever reason validate_kwarg_typing does not play well with this change ONLY IN GITHUB ACTIONS. **Tests pass internally with or without this change.** Reviewed By: esantorella Differential Revision: D61480862
|
This pull request was exported from Phabricator. Differential Revision: D61480862 |
mpolson64
force-pushed
the
export-D61480862
branch
from
a0e8a2e
to
92face9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: For whatever reason validate_kwarg_typing does not play well with this change ONLY IN GITHUB ACTIONS. Tests pass internally with or without this change.
Differential Revision: D61480862