Skip to content
This repository has been archived by the owner on May 7, 2021. It is now read-only.

Board components #2729

Merged
merged 52 commits into from
Jul 30, 2018
Merged

Board components #2729

merged 52 commits into from
Jul 30, 2018

Conversation

sahil143
Copy link
Contributor

@sahil143 sahil143 commented Jul 22, 2018

Note: If there are pending changes to the PR, prefix the PR title with "WIP" and add the label "DO NOT MERGE"

Mandatory

  • What does this PR do?

  • This PR adds the board components to board view.

  • Space with workItems on board: /sbudhwar-preview/Agile/plan/board?boardContextId=1c21af72-59ab-43d7-a84c-e76ee8ed3342

  • What issue/task does this PR references?
    https://openshift.io/openshiftio/openshiftio/plan/detail/2073

  • Are the tests Included?
    Yes


Optional

  • Is the documentation Included?

  • Are the Release Notes included?

  • @mention(s) to expected reviewer(s) included

@alien-ike
Copy link
Collaborator

alien-ike commented Jul 22, 2018

Ike Plugins (test-keeper)

Thank you @sahil143 for this contribution!

It seems that this PR already contains some added or changed tests. Good job!

Your plugin configuration is stored in the file.

@centos-ci
Copy link
Collaborator

@sahil143 Your image is available in the registry. Run docker pull registry.devshift.net/fabric8-ui/fabric8-planner:SNAPSHOT-PR-2729 && docker run -it -p 5000:8080 registry.devshift.net/fabric8-ui/fabric8-planner:SNAPSHOT-PR-2729 and visit http://localhost:5000 to access it.

1 similar comment
@centos-ci
Copy link
Collaborator

@sahil143 Your image is available in the registry. Run docker pull registry.devshift.net/fabric8-ui/fabric8-planner:SNAPSHOT-PR-2729 && docker run -it -p 5000:8080 registry.devshift.net/fabric8-ui/fabric8-planner:SNAPSHOT-PR-2729 and visit http://localhost:5000 to access it.

@centos-ci
Copy link
Collaborator

@sahil143 Your image is available in the registry. Run docker pull registry.devshift.net/fabric8-ui/fabric8-planner:SNAPSHOT-PR-2729 && docker run -it -p 5000:8080 registry.devshift.net/fabric8-ui/fabric8-planner:SNAPSHOT-PR-2729 and visit http://localhost:5000 to access it.

2 similar comments
@centos-ci
Copy link
Collaborator

@sahil143 Your image is available in the registry. Run docker pull registry.devshift.net/fabric8-ui/fabric8-planner:SNAPSHOT-PR-2729 && docker run -it -p 5000:8080 registry.devshift.net/fabric8-ui/fabric8-planner:SNAPSHOT-PR-2729 and visit http://localhost:5000 to access it.

@centos-ci
Copy link
Collaborator

@sahil143 Your image is available in the registry. Run docker pull registry.devshift.net/fabric8-ui/fabric8-planner:SNAPSHOT-PR-2729 && docker run -it -p 5000:8080 registry.devshift.net/fabric8-ui/fabric8-planner:SNAPSHOT-PR-2729 and visit http://localhost:5000 to access it.

@sahil143 sahil143 changed the title [WIP] Board components Board components Jul 24, 2018
@sahil143 sahil143 requested a review from sanbornsen July 24, 2018 17:10
@centos-ci
Copy link
Collaborator

@sahil143 Your image is available in the registry. Run docker pull registry.devshift.net/fabric8-ui/fabric8-planner:SNAPSHOT-PR-2729 && docker run -it -p 5000:8080 registry.devshift.net/fabric8-ui/fabric8-planner:SNAPSHOT-PR-2729 and visit http://localhost:5000 to access it.

Copy link
Contributor

@Raunak1203 Raunak1203 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sahil143 I can't see anything in board view except state column, but space which you have given in the template has cards. Am I missing something?

peek 2018-07-25 10-08

As discussed, Could you please check -

  1. version conflict error while updating workitem
  2. opening full detail view is not working from the quick-preview

@sahil143
Copy link
Contributor Author

No @Raunak1203, You are not missing anything That is the correct behavior as of now because existing workitem are not migrated to board view. I sent patch requests for workitem update explicitly to get few cards on the board. Please use the space given in template to review the board view.

@michaelkleinhenz ^^

@centos-ci
Copy link
Collaborator

@sahil143 Your image is available in the registry. Run docker pull registry.devshift.net/fabric8-ui/fabric8-planner:SNAPSHOT-PR-2729 && docker run -it -p 5000:8080 registry.devshift.net/fabric8-ui/fabric8-planner:SNAPSHOT-PR-2729 and visit http://localhost:5000 to access it.

2 similar comments
@centos-ci
Copy link
Collaborator

@sahil143 Your image is available in the registry. Run docker pull registry.devshift.net/fabric8-ui/fabric8-planner:SNAPSHOT-PR-2729 && docker run -it -p 5000:8080 registry.devshift.net/fabric8-ui/fabric8-planner:SNAPSHOT-PR-2729 and visit http://localhost:5000 to access it.

@centos-ci
Copy link
Collaborator

@sahil143 Your image is available in the registry. Run docker pull registry.devshift.net/fabric8-ui/fabric8-planner:SNAPSHOT-PR-2729 && docker run -it -p 5000:8080 registry.devshift.net/fabric8-ui/fabric8-planner:SNAPSHOT-PR-2729 and visit http://localhost:5000 to access it.

Copy link
Contributor

@Raunak1203 Raunak1203 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sahil143

  1. 404 error is thrown if I am in board view and I click on Profile and after that side Panel and Board column disappears.

peek 2018-07-26 12-42

  1. Created_by should be User Name, currently in quick preview(User Name) and card(user id)
    screenshot from 2018-07-26 13-26-07

  2. Number of cards in a particular state is confusing. It looks like Column in increasing order(not the total cards in a particular state) @Veethika @sunilmalagi

4.child iteration on hover should show /parentIteration/childIteration( Actual- /parentIterationchildIteration)

  1. My filters delete is not working in board view . Clicking 'My filter' opens list view but if we try to delete in board view , nothing happens.

@centos-ci
Copy link
Collaborator

@sahil143 Your image is available in the registry. Run docker pull quay.io/openshiftio/rhel-fabric8-ui-fabric8-planner:SNAPSHOT-PR-2729 && docker run -it -p 5000:8080 quay.io/openshiftio/rhel-fabric8-ui-fabric8-planner:SNAPSHOT-PR-2729 and visit http://localhost:5000 to access it.

@Raunak1203
Copy link
Contributor

Raunak1203 commented Jul 30, 2018

@sahil143 card disappears if I change it from any of the child iterations to root iteration
peek 2018-07-30 20-17

@sahil143
Copy link
Contributor Author

sahil143 commented Jul 30, 2018

@Raunak1203 That is expected behavior. That workItem never belonged to Work Item board. It belonged to Execution Board only. So If you don't assign it to any of the iterations It won't appear on any of the board.

Copy link
Contributor

@Raunak1203 Raunak1203 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Above fixes LGTM and tested on space with workItems on board:

  1. /sbudhwar-preview/Agile/plan/board?boardContextId=1c21af72-59ab-43d7-a84c-e76ee8ed3342
    and on space
  2. /rbajpai-preview/test_board_view/plan?q=(space:300db7fe-9065-44f8-97a1-84bba8999431%20$AND%20typegroup.name:Scenarios)&showTree=true

because existing workitems are not migrated to board view
and also States updated on board view will not update States in list view

@centos-ci
Copy link
Collaborator

@sahil143 Your image is available in the registry. Run docker pull quay.io/openshiftio/rhel-fabric8-ui-fabric8-planner:SNAPSHOT-PR-2729 && docker run -it -p 5000:8080 quay.io/openshiftio/rhel-fabric8-ui-fabric8-planner:SNAPSHOT-PR-2729 and visit http://localhost:5000 to access it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants