Skip to content
This repository has been archived by the owner on Mar 11, 2021. It is now read-only.

SDD Template is now legacy #2379

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

michaelkleinhenz
Copy link
Collaborator

@michaelkleinhenz michaelkleinhenz commented Dec 14, 2018

This sets can_construct to no for the SDD template, effectively making it unavailable for new Spaces.

This sets `can_create` to `no` for the SDD template, effectively making it unavailable for new Spaces.
@alien-ike
Copy link

Ike Plugins (test-keeper)

Thank you @michaelkleinhenz for this contribution!

It appears that no tests have been added or updated in this PR.

Automated tests give us confidence in shipping reliable software. Please add some as part of this change.

If you are an admin or the reviewer of this PR and you are sure that no test is needed then you can use the command /ok-without-tests as a comment to make the status green.

For more information please head over to official documentation. You can find there how to configure the plugin.

@michaelkleinhenz
Copy link
Collaborator Author

/ok-without-tests

@alien-ike
Copy link

Hey @michaelkleinhenz! It seems you tried to trigger /ok-without-tests command, but this will not have any effect due to insufficient permission. You have to be admin or requested reviewer or pull request approver, but not pull request creator for this command to take an effect.

@baijum
Copy link
Contributor

baijum commented Dec 17, 2018

/ok-without-tests

@alien-ike
Copy link

Hey @baijum! It seems you tried to trigger /ok-without-tests command, but this will not have any effect due to insufficient permission. You have to be admin or requested reviewer or pull request approver, but not pull request creator for this command to take an effect.

@baijum
Copy link
Contributor

baijum commented Dec 17, 2018

/ok-without-tests

Copy link
Contributor

@baijum baijum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants