This repository has been archived by the owner on Mar 11, 2021. It is now read-only.
WIP: Update rendering package with minimal influence #2077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOT READY FOR REVIEW YET.
This updates the rendering package. The most prominent change is that the markup now has its own
string-based type. Admittedly, this is only for clarity.I've also added a lot more tests cases.
But the major addition is that there's a new field called
Renderedin theMarkupContentstruct. That one is not used in this PR. It was added to support setting and getting markdown fields likesystem.descriptionwithout the additional hassle of adding two extract fields for the markup and rendered output, namelysystem.description.markup,system.description.description.See #2070