Feature: Add an option to control the discretization of colormap #1678
+14
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwestphal
reviewed
Oct 25, 2024
| @@ -246,6 +246,10 @@ | |||
| "type": "double_vector", | |||
| "default_value": "0.0, 0.0, 0.0, 0.0, 0.4, 0.9, 0.0, 0.0, 0.8, 0.9, 0.9, 0.0, 1.0, 1.0, 1.0, 1.0" | |||
| }, | |||
| "discretization" : { | |||
| "type": "bool", | |||
There was a problem hiding this comment.
This option definitely should not be a bool but an int I think.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1678 +/- ##
=======================================
Coverage 96.90% 96.90%
=======================================
Files 105 105
Lines 8629 8634 +5
=======================================
+ Hits 8362 8367 +5
Misses 267 267 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue:
This work addresses the Issue: #228
Current Progress
Over the past two weeks, I have made significant progress on #228, with my work available for review in the following commits:
These commits introduce a new CLI option and extend the vtkF3DRenderer class to handle this option.
Please note that the PR isn’t fully complete yet, as it does not fully resolve #228. I will continue to work on it to ensure that all aspects are addressed.
Since I’ve already spent two weeks on this task, I wanted to report my progress, especially as we’re working remotely.
Next Steps
I will review the VTK documentation to learn how to adjust color settings, specifically focusing on the vtkDiscretizableColorTransferFunction.