-
-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Quake MDL feature #1591
Open
Youva
wants to merge
24
commits into
f3d-app:master
Choose a base branch
from
Youva:quake-mdl-feature
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Quake MDL feature #1591
Changes from all commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
9d96975
Adding preliminary Quake1 MDL plugin.
malespiaut 31e502a
Fixing some vector types error in vtkQuakeMDLReader.
malespiaut 614385b
Fixing some formatting error (whitespaces) in vtkQuakeMDLReader.
malespiaut 802a5ef
Fixing typo in vtkQuakeMDLReader.
malespiaut bccc126
Cleaning out unnecessary code.
malespiaut b294c6a
Add importer
Youva 6f7832f
Removed hardcoded path
Youva 803caa9
Fixed crash due to memory allocation on normals and interpolated fram…
Youva 415e7a5
Fix for test on --scan-plugins leading to crash
Youva 3fe48e9
Merge remote-tracking branch 'origin-f3d/master' into quake-mdl-fork.
Youva f390b60
Removed modification at line 255, engine.cxx
Youva 18e2348
Formatting
Youva b4b49b4
Formatting
Youva 7cc7e0c
Formatting
Youva 845a0e6
Fixed build errors w/ strict_build
Youva 2b9de40
Update vtkQuakeMDLImporter.cxx
Youva e22fe52
Update vtkQuakeMDLImporter.cxx
Youva 71a6bda
Fixed override updateTimeStep.
Youva 77f65ee
Removed some warnings
Youva 9b5e644
Applied style.
Youva c6cba7f
Changed push_back to emplace_back
Youva 59b17e1
Return bool l. 432
Youva 81ad26f
Fix unusedStructMember and containerOutOfBounds
Youva 98f7e72
Coding style modification.
Youva File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
diff a/plugins/alembic/module/vtkF3DAlembicReader.h b/plugins/alembic/module/vtkF3DAlembicReader.h (rejected hunks) | ||
@@ -14,10 +14,10 @@ | ||
#ifndef vtkF3DAlembicReader_h | ||
#define vtkF3DAlembicReader_h | ||
|
||
+#include <memory> | ||
#include <vtkNew.h> | ||
#include <vtkPolyDataAlgorithm.h> | ||
#include <vtkVersion.h> | ||
-#include <memory> | ||
|
||
class vtkF3DAlembicReader : public vtkPolyDataAlgorithm | ||
{ | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. you can remove this file |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -189,6 +189,15 @@ f3d_plugin_declare_reader( | |
FORMAT_DESCRIPTION "3D Gaussian splats" | ||
) | ||
|
||
f3d_plugin_declare_reader( | ||
NAME QuakeMDL | ||
EXTENSIONS mdl | ||
MIMETYPES application/vnd.mdl | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. do you have a small .mdl file with a creative commons license ? |
||
VTK_IMPORTER vtkQuakeMDLImporter | ||
FORMAT_DESCRIPTION "Quake 1 MDL model" | ||
) | ||
|
||
|
||
f3d_plugin_build( | ||
NAME native | ||
VERSION 1.0 | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,6 @@ | ||
set(classes | ||
vtkF3DSplatReader | ||
vtkQuakeMDLImporter | ||
) | ||
|
||
set(_no_install "") | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no need to move this