Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add colormap file support #1309

Merged
merged 8 commits into from
Mar 28, 2024
Merged

Add colormap file support #1309

merged 8 commits into from
Mar 28, 2024

Conversation

Meakk
Copy link
Contributor

@Meakk Meakk commented Mar 11, 2024

No description provided.

@Meakk Meakk self-assigned this Mar 11, 2024
@github-actions GitHub Actions
Copy link

You are modifying libf3d public API! ⚠️Please update bindings accordingly⚠️!
You can find them in their respective directories: python, java, webassembly.

@Meakk Meakk mentioned this pull request Mar 11, 2024
Closed
@codecov Codecov
Copy link

codecov bot commented Mar 11, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 98.71795% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 96.59%. Comparing base (108cc36) to head (f1781a8).
Report is 1 commits behind head on master.

Files Patch % Lines
library/src/image.cxx 94.11% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1309      +/-   ##
==========================================
+ Coverage   96.48%   96.59%   +0.10%     
==========================================
  Files         146      147       +1     
  Lines        8793     8865      +72     
==========================================
+ Hits         8484     8563      +79     
+ Misses        309      302       -7

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

snoyer
snoyer reviewed Mar 12, 2024
View reviewed changes
application/F3DColorMapTools.cxx Outdated Show resolved Hide resolved
library/src/image.cxx Outdated Show resolved Hide resolved
mwestphal
mwestphal reviewed Mar 12, 2024
View reviewed changes
doc/user/COLOR_MAPS.md Outdated Show resolved Hide resolved
mwestphal
mwestphal reviewed Mar 12, 2024
View reviewed changes
doc/user/COLOR_MAPS.md Outdated Show resolved Hide resolved
mwestphal
mwestphal reviewed Mar 12, 2024
View reviewed changes
library/public/image.h Outdated Show resolved Hide resolved
@Meakk Meakk requested a review from mwestphal March 16, 2024 20:48
mwestphal
mwestphal reviewed Mar 16, 2024
View reviewed changes
doc/user/COLOR_MAPS.md Outdated Show resolved Hide resolved
mwestphal
mwestphal reviewed Mar 16, 2024
View reviewed changes
doc/user/COLOR_MAPS.md Outdated Show resolved Hide resolved
mwestphal
mwestphal reviewed Mar 16, 2024
View reviewed changes
doc/user/COLOR_MAPS.md Outdated Show resolved Hide resolved
mwestphal
mwestphal requested changes Mar 16, 2024
View reviewed changes
Copy link
Contributor

@mwestphal mwestphal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

few small changes

mwestphal
mwestphal requested changes Mar 23, 2024
View reviewed changes
Copy link
Contributor

@mwestphal mwestphal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small changes needed

@Meakk Meakk requested a review from mwestphal March 25, 2024 20:13
@Meakk Meakk merged commit 68742f5 into f3d-app:master Mar 28, 2024
42 checks passed
@mwestphal mwestphal mentioned this pull request Mar 31, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snoyer snoyer snoyer left review comments

@mwestphal mwestphal mwestphal approved these changes

Assignees

@Meakk Meakk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Meakk @snoyer @mwestphal