-
-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding watch option using dmon #1308
Conversation
You are modifying libf3d public API! |
3222afc
to
f73f8df
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1308 +/- ##
==========================================
+ Coverage 96.45% 96.48% +0.03%
==========================================
Files 146 146
Lines 8765 8793 +28
==========================================
+ Hits 8454 8484 +30
+ Misses 311 309 -2 ☔ View full report in Codecov by Sentry. |
9373cca
to
096ba11
Compare
27feac3
to
0242872
Compare
Looks like you already have the implementation details covered so I'm left with nitpicking naming:
tldr: void Render() { SoftRender = true; } // do the thing = don't actually o_O
if (SoftRender) ForceRender(); // if soft then forceful o_O void RequestRender() { RenderRequested = true; } // request the thing = mark it as requested ^_^
if (RenderRequested) Render(); // do the thing if asked ^_^ |
As always, the easiest to find out how to do the right thing is just to do the wrong thing and wait for people to fix it for you, thanks @snoyer :) |
Co-authored-by: Michael MIGLIORE <[email protected]>
This reverts commit fc081f9.
22e6ffa
to
fd4a6d5
Compare
This reverts commit 89c070e.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
small typo to fix and good to go!
Co-authored-by: Michael MIGLIORE <[email protected]>
This add support for an "--watch" cli option where the current file is reloaded automatically if changed on disk.
It relies on https://github.com/septag/dmon for detecting the changes.
In order to support this properly, F3DStarter is reworked with a proper event loops that currently supports:
This also adds a test for it on linux/apple/windows
Script used:
Peek.2024-03-17.12-09.mp4
Fix: #86