-
-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add metadata to f3d::image
#1273
Conversation
You are modifying libf3d public API! |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1273 +/- ##
==========================================
- Coverage 96.59% 96.57% -0.02%
==========================================
Files 138 138
Lines 8446 8494 +48
==========================================
+ Hits 8158 8203 +45
- Misses 288 291 +3 ☔ View full report in Codecov by Sentry. |
supposedly a fixed bug https://trac.cppcheck.net/ticket/10368 |
this approach looks fine to me. Wdyt @Meakk ? |
a8aac1c
to
3f8eb1d
Compare
There was an issue that required rewriting history. Please cherry pick your commits on f3d-app/f3d master. |
7aa4dda
to
3f8eb1d
Compare
re-opening for no reason, nothing happened, there was no git accident, at all, ever |
Add support for metadata key,value pairs on
f3d::image
objects.Saving and loading is currently only implemented for PNG format. It may be technically possible for other formats (eg. JPEG using Exif data) assuming VTK supports it.
Metadata would be used by future features to embed data in F3D's render, such as camera parameters, rendering options, ...