Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add metadata to f3d::image #1273

Merged
merged 7 commits into from
Feb 12, 2024
Merged

add metadata to f3d::image #1273

merged 7 commits into from
Feb 12, 2024

Conversation

snoyer
Copy link
Contributor

@snoyer snoyer commented Feb 9, 2024

Add support for metadata key,value pairs on f3d::image objects.

Saving and loading is currently only implemented for PNG format. It may be technically possible for other formats (eg. JPEG using Exif data) assuming VTK supports it.

Metadata would be used by future features to embed data in F3D's render, such as camera parameters, rendering options, ...

Copy link

github-actions bot commented Feb 9, 2024

You are modifying libf3d public API! ⚠️Please update bindings accordingly⚠️!
You can find them in their respective directories: python, java, webassembly.

Copy link

codecov bot commented Feb 9, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (3f8eb1d) 96.59% compared to head (b5dedd4) 96.57%.
Report is 1 commits behind head on master.

Files Patch % Lines
library/src/image.cxx 97.91% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1273      +/-   ##
==========================================
- Coverage   96.59%   96.57%   -0.02%     
==========================================
  Files         138      138              
  Lines        8446     8494      +48     
==========================================
+ Hits         8158     8203      +45     
- Misses        288      291       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@snoyer
Copy link
Contributor Author

snoyer commented Feb 9, 2024

library/src/image.cxx:56:23: style: Variable 'key' is not assigned a value. [unassignedVariable]
    for (const auto& [key, value] : this->Metadata)
                      ^

supposedly a fixed bug https://trac.cppcheck.net/ticket/10368

@mwestphal
Copy link
Contributor

this approach looks fine to me. Wdyt @Meakk ?

@mwestphal
Copy link
Contributor

There was an issue that required rewriting history. Please cherry pick your commits on f3d-app/f3d master.

@snoyer
Copy link
Contributor Author

snoyer commented Feb 11, 2024

re-opening for no reason, nothing happened, there was no git accident, at all, ever

@snoyer snoyer reopened this Feb 11, 2024
library/src/image.cxx Outdated Show resolved Hide resolved
library/src/image.cxx Outdated Show resolved Hide resolved
python/F3DPythonBindings.cxx Show resolved Hide resolved
library/src/image.cxx Outdated Show resolved Hide resolved
library/src/image.cxx Outdated Show resolved Hide resolved
library/src/image.cxx Outdated Show resolved Hide resolved
library/src/image.cxx Outdated Show resolved Hide resolved
library/testing/TestSDKImage.cxx Outdated Show resolved Hide resolved
@Meakk Meakk merged commit b87ba39 into f3d-app:master Feb 12, 2024
40 checks passed
@snoyer snoyer deleted the image-metadata branch February 12, 2024 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants