-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
93 add test for resetting the poses in vectorized env #94
Conversation
other tests and f110 env: change default map from Vegas to Spielberg because new reset needs centerline. observation: add +0.5 to max scan range to avoid rays slightly above max range.
Implemented automatic reset methods. Add test to auto-reset in vec environments. The reset methods use the centerline waypoints to sample starting poses. @hzheng40 please review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just had some questions.
|
||
x, y = wp[0], wp[1] | ||
if n_agents > 1: | ||
lat_offset = rnd_sign * (-1.0) ** i * (1.0 / n_agents) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i'm not sure if it's i-th power or i(1/n)-th power?
) # first wp id with dist > mind, len of the interval btw first/last wp | ||
pnt_id = current_wp_id # moving pointer to scan the next waypoints | ||
dist = 0.0 | ||
while dist <= max_dist: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think this whole while loop is only needed if you don't have the arclengths in the track.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's not exactly the same but even if there's a speedup it won't be that different
gym/f110_gym/envs/f110_env.py
Outdated
# others | ||
import numpy as np | ||
|
||
# gl | ||
import pyglet |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
might need to pull in changes from the rendering pr
Add tests for vectorized environments, closes #93