101 decoupled action spaces #102
Conversation
gym/f110_gym/envs/action.py
Outdated
|
|
||
| self.steering_low, self.steering_high = params["s_min"], params["s_max"] | ||
| self.velocity_low, self.velocity_high = params["v_min"], params["v_max"] | ||
| self._type = "speed" |
There was a problem hiding this comment.
typo? also should add steering so it's specified
gym/f110_gym/envs/action.py
Outdated
| class SteeringSpeedAction(SteerAction): | ||
| def __init__(self, params: Dict) -> None: | ||
| super().__init__() | ||
| self._type = "speed" |
There was a problem hiding this comment.
add steering so it's specified
gym/f110_gym/envs/action.py
Outdated
|
|
||
| @staticmethod | ||
| def from_string(action: str): | ||
| if action == "angle": |
There was a problem hiding this comment.
again, should specifiy steering_angle and steering_speed, just to be less confusing
|
@AhmadAmine998 I pulled in the updated tests and it's failing right now. You'll probably have to update the tests to use the decoupled action spaces. |
…nth_gym into 101-decoupled-action-spaces
I updated the initialization of the action space to be compatible with specifying only one control input as a string. The old tests passed and I now updated the tests to use the decoupled action specification. This way it is compatible with legacy code while still having updated tests |
No description provided.