-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get rid of tabindex #540
base: next
Are you sure you want to change the base?
Get rid of tabindex #540
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I partly disagree. Every other page than the frontpage should have tabindexes removed.
But I think the frontpage should be in this order: Quickbuy -> buy -> restart -> menu -> tilmeld. I feel like it's more intuitive for them to be in that order🤔 Even though it isn't standard web. My main argument for us to ignore the web in this sense, is the way it's accessed (through the stregkiosk) it doesn't feel like a webpage, it's closer to a kind of game.
The first time I used the stregsystem, I wanted to access the menu, so I pressed |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #540 +/- ##
=======================================
Coverage 80.80% 80.80%
=======================================
Files 40 40
Lines 3809 3809
Branches 481 481
=======================================
Hits 3078 3078
Misses 675 675
Partials 56 56 ☔ View full report in Codecov by Sentry. |
Should we maybe make a kind of design guideline? To point to, with discussions like these 🤔 |
Sounds good to me. |
Tabindexes change the expected flow of the page to make it less intuitive, we should get rid of them.
Partially ununfixes #494