Add support for activerecord 7.2, ruby 3.3 #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmpage
force-pushed
the
jmp/add-activerecord-7.2-ruby-3.3-support
branch
3 times, most recently
from
23cd800
to
cac6c52
Compare
jmpage
force-pushed
the
jmp/add-activerecord-7.2-ruby-3.3-support
branch
from
cac6c52
to
52890c4
Compare
jmpage
commented
Sep 17, 2024
| @@ -17,7 +19,7 @@ | |||
| Thread.new do | |||
| listener_loop(**listener_options) | |||
| ensure | |||
| base_class.clear_active_connections! | |||
There was a problem hiding this comment.
NOTE: delegation to the connection handler was deprecated in activerecord 7.1 and removed in activerecord 7.2.
kraila
approved these changes
Sep 17, 2024
jmpage
commented
Sep 17, 2024
Comment on lines
+43
to
+44
| - activerecord: '7.2' | ||
| ruby: '3.0' |
There was a problem hiding this comment.
NOTE: activerecord 7.2 requires ruby 3.1 or greater. I added this exclusion so that we can continue to support ruby 3.0 for the time being.
jmpage
commented
Sep 17, 2024
| @@ -1,5 +1,7 @@ | |||
| # frozen_string_literal: true | |||
|
|
|||
| require "ostruct" | |||
There was a problem hiding this comment.
We must have had a dependency which was loading this as tests were failing because OpenStruct was not loaded. I haven't tracked this down because our old build logs appear to have passed the retention period and I don't think that it's worth the effort to try to reproduce successful builds without this import.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What did we change?
Why are we doing this?
Resolves #34 so that people who are using rails 7.2 can also use this gem.
NOTES
Ruby 3.0 has been EOL for almost 5 months. I figure that a breaking change for dropping this probably warrants a separate release. Rails 6.1 is EOL in 2 weeks, so it probably makes sense to drop support for that simultaneously.
How was it tested?