Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: run tests against modern ruby and pg versions #30

Closed
wants to merge 4 commits into from

Conversation

jmpage
Copy link
Contributor

@jmpage jmpage commented Dec 8, 2023

This change tests this gem against modern versions of the pg gem and ruby.

Notes:

  • Drops support for activerecord 5.2 to sidestep compatibility issues with ruby 3+ in builds.
  • Omits builds for ruby 3.2 as it's tricky to get all the appraised pg versions to install in ruby 3.2

This also modifies tests to run against one of three variable dependencies (activerecord, pg, ruby) at a time while pinning the other two to the latest supported version. This is done so that we don't greatly expand the number of test runs that we are performing for this gem. Were we to just add the new versions to the existing matrix, we would be running 100 variations per workflow run. The drawback of this is that there may be some sets of dependencies which are not compatible with each other which our tests may miss because of their non-exhaustive nature.

I did not attempt to de-duplicate the jobs as part of this PR.

@jmpage jmpage force-pushed the jmp/build-against-modern-versions branch 2 times, most recently from 0e41d97 to a25df04 Compare December 8, 2023 14:47
@jmpage jmpage marked this pull request as draft December 8, 2023 14:56
@jmpage jmpage force-pushed the jmp/build-against-modern-versions branch 3 times, most recently from 967885d to 8594c77 Compare December 8, 2023 15:40
@jmpage jmpage force-pushed the jmp/build-against-modern-versions branch from 1ab2558 to d134724 Compare December 11, 2023 14:27
@jmpage jmpage marked this pull request as ready for review December 11, 2023 14:36
@jmpage jmpage force-pushed the jmp/build-against-modern-versions branch from 6d556d9 to d134724 Compare December 11, 2023 14:38
@jmpage jmpage marked this pull request as draft December 11, 2023 15:02
@jmpage
Copy link
Contributor Author

jmpage commented Dec 11, 2023

Replaced by #31

@jmpage jmpage closed this Dec 11, 2023
@jmpage jmpage deleted the jmp/build-against-modern-versions branch December 11, 2023 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant