Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING CHANGE: Remove blogic option. Blogic is now always enabled by default. #480

Merged
merged 1 commit into from
Aug 1, 2023

Conversation

jeswr
Copy link
Collaborator

@jeswr jeswr commented Aug 1, 2023

BREAKING CHANGE: blogic option has been removed.

… by default.

BREAKING CHANGE: `blogic` option has been removed.
@jeswr jeswr requested a review from josd August 1, 2023 13:30
@josd
Copy link
Contributor

josd commented Aug 1, 2023

it is not a breaking change because eye still accepts --blogic but it DEPRECATED and today it is not needed as we automatically detect this logic mode.

It is commented in the code https://github.com/eyereasoner/eye/blob/beccc014842e7b473970b097796f3c5ce0299fcd/eye.pl#L920

@jeswr
Copy link
Collaborator Author

jeswr commented Aug 1, 2023

I've set it as a breaking change over here because:

  1. Using the blogic option will create now create type errors here as I have removed that option from the typescript interface. So users will need to migrate by removing their use of that option.
  2. blogic results are returned even when blogic: false is set (Typescript users will hit the above problem first, but plain JavaScript users won't)

Unless there is a chance of the option becoming necessary again I'm inclined to keep these breaking changes as it is a small migration path and we don't have a huge user base for blogic at the moment so only a small number of users will be impacted.

@jeswr jeswr merged commit c277d37 into main Aug 1, 2023
19 checks passed
@jeswr jeswr deleted the breaking/no-blogic branch August 1, 2023 13:52
@josd
Copy link
Contributor

josd commented Aug 1, 2023

OKOK, that fine @jeswr

@jeswr
Copy link
Collaborator Author

jeswr commented Aug 1, 2023

🎉 This PR is included in version 6.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@jeswr jeswr added the released label Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants