-
Notifications
You must be signed in to change notification settings - Fork 1
Added Shkoliar_GridColors module JSON report #4
base: master
Are you sure you want to change the base?
Conversation
Hi @shkoliar thanks for the PR. As of yet, I'm not sure if we can complete this PR right away. The current status of the repo is that it is under discussion with ExtDN members to see if this project makes any sense. Next, the idea would be to test this with extensions that we can actually validate ourselves (meaning, approved extensions created by ExtDN extension providers), before bringing it to a wider audience. This was not made clear at all in the docs of this repo so far, so I've updated them anyway: https://github.com/extdn/extdn-badge-repository/blob/master/README.md However, then you came in. You submitted one of your extensions. What would be the main reason for creating such a PR? Are you actually eager to create an ExtDN badge so you can put this on a website somewhere? And wouldn't you then be interested in becoming a ExtDN member to begin with? :) Also, could you enhance the PR a bit, so that it includes an |
Hi @jissereitsma! Yeah, initially readme wasn't clear about whose extensions are allowed to apply. :)
I wanted to check how the badge works itself and currently, I have no intent to place the badge somewhere. :)
Not sure if I'm able to comply with all membership requirements right now.
Sure, if it has a sense for current PR with the extension which is not from an ExtDN extension provider. |
Thanks for the quick reply. The membership requirements can be found once applying for it, via the form link on the ExtDN site. Let me know once the URLs are added. Would be interesting to play around with automatic checking :) |
👍 Added! Basically there is nothing to check, as module mainly written with JavaScript, unless you are planning to add also checks of JS and XML files 🙂 |
Thanks for the update. Still, I think it will be interesting to do something with external modules that are available for free on GitHub, so I will keep the PR open for now until I have some time to work on this again. |
Added the JSON file to test the extension badge.