Skip to content
This repository has been archived by the owner on Jan 16, 2023. It is now read-only.

Added Shkoliar_GridColors module JSON report #4

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

shkoliar
Copy link

Added the JSON file to test the extension badge.

@jissereitsma
Copy link
Contributor

Hi @shkoliar thanks for the PR. As of yet, I'm not sure if we can complete this PR right away. The current status of the repo is that it is under discussion with ExtDN members to see if this project makes any sense. Next, the idea would be to test this with extensions that we can actually validate ourselves (meaning, approved extensions created by ExtDN extension providers), before bringing it to a wider audience. This was not made clear at all in the docs of this repo so far, so I've updated them anyway: https://github.com/extdn/extdn-badge-repository/blob/master/README.md

However, then you came in. You submitted one of your extensions. What would be the main reason for creating such a PR? Are you actually eager to create an ExtDN badge so you can put this on a website somewhere? And wouldn't you then be interested in becoming a ExtDN member to begin with? :)

Also, could you enhance the PR a bit, so that it includes an information_url and a repository_url? This repository_url will be important, so we can enhance the tooling to validate new or existing entries automatically.

@shkoliar
Copy link
Author

shkoliar commented Mar 25, 2020

Hi @jissereitsma!

Yeah, initially readme wasn't clear about whose extensions are allowed to apply. :)

What would be the main reason for creating such a PR? Are you actually eager to create an ExtDN badge so you can put this on a website somewhere?

I wanted to check how the badge works itself and currently, I have no intent to place the badge somewhere. :)

And wouldn't you then be interested in becoming a ExtDN member to begin with? :)

Not sure if I'm able to comply with all membership requirements right now.

Also, could you enhance the PR a bit, so that it includes an information_url and a repository_url? This repository_url will be important, so we can enhance the tooling to validate new or existing entries automatically.

Sure, if it has a sense for current PR with the extension which is not from an ExtDN extension provider.

@jissereitsma
Copy link
Contributor

Thanks for the quick reply. The membership requirements can be found once applying for it, via the form link on the ExtDN site.

Let me know once the URLs are added. Would be interesting to play around with automatic checking :)

@shkoliar
Copy link
Author

Let me know once the URLs are added. Would be interesting to play around with automatic checking :)

👍 Added! Basically there is nothing to check, as module mainly written with JavaScript, unless you are planning to add also checks of JS and XML files 🙂

@jissereitsma
Copy link
Contributor

Thanks for the update. Still, I think it will be interesting to do something with external modules that are available for free on GitHub, so I will keep the PR open for now until I have some time to work on this again.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants