Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX] Show translated product in teaser plugin #210

Merged
merged 3 commits into from
Oct 9, 2024

Conversation

extcode
Copy link
Owner

@extcode extcode commented Oct 9, 2024

Relates: #205

@extcode extcode self-assigned this Oct 9, 2024
@extcode extcode changed the title [TASK] Add acceptance test for teaser plugin [BUGFIX] Show translated product in teaser plugin Oct 9, 2024
extcode and others added 2 commits October 9, 2024 12:35
Translating products means using the language
overlay. As a result the returned object has
all properties of the translation but still the
UID of the original object. As a result the
`orderByField()` failed as it compared the UIDs
of the translated objects against objects that
still had the original UIDs.

Fixes: #205
@extcode extcode force-pushed the bugfix/205-show-translated-products-in-teaser-plugin branch from 191da82 to 9305dad Compare October 9, 2024 10:35
@extcode extcode force-pushed the bugfix/205-show-translated-products-in-teaser-plugin branch from c45dc2a to d080573 Compare October 9, 2024 11:21
@extcode extcode merged commit 7887669 into main Oct 9, 2024
10 checks passed
@extcode extcode deleted the bugfix/205-show-translated-products-in-teaser-plugin branch October 9, 2024 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants