Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Task] Cleanup tests #586

Merged
merged 2 commits into from
Oct 16, 2024
Merged

[Task] Cleanup tests #586

merged 2 commits into from
Oct 16, 2024

Conversation

extcode
Copy link
Owner

@extcode extcode commented Oct 14, 2024

No description provided.

@extcode extcode requested a review from rintisch October 14, 2024 19:42
@extcode extcode self-assigned this Oct 14, 2024
@extcode extcode changed the title Task/cleanup test [Task] Cleanup tests Oct 14, 2024
Copy link
Collaborator

@rintisch rintisch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but the changes in /Classes/Controller/Cart were already done in #585. Might be easier to remove them here? Unsure whether it results otherwise in conflict or whether git sees that it are the same changes....

@extcode
Copy link
Owner Author

extcode commented Oct 15, 2024

After merging and rebasing they will be automatically removed. The changes are duplicated to have a green pipeline for the PR.

@rintisch
Copy link
Collaborator

Okay, now I understand :)

@extcode extcode merged commit f6853a4 into main Oct 16, 2024
11 checks passed
@extcode extcode deleted the task/cleanup_test branch October 16, 2024 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants