Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add locale date string #197

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

feat: add locale date string #197

wants to merge 2 commits into from

Conversation

xrr2016
Copy link

@xrr2016 xrr2016 commented May 23, 2019

Need locale date string.

@dougwilson dougwilson added the pr label Mar 18, 2020
dougwilson
dougwilson suggested changes Mar 20, 2020
View reviewed changes
Copy link
Contributor

@dougwilson dougwilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your pull request! Sorry it fell through the cracks, as it were. Can you elaborate more on the use-case for this? Also please add docs and tests for this new feature if you would like to see it land.

@UlisesGascon
Copy link
Member

Hi @xrr2016! If you need help with the tests. Please ping me and I will try to help you 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dougwilson dougwilson dougwilson requested changes

Assignees
No one assigned
Labels
needs docs needs rebase needs tests pr
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xrr2016 @UlisesGascon @dougwilson