Replace node:fetch with native node fetch #71
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
katayama8000
force-pushed
the
delete_node-fetch
branch
from
159dfbe to
d1d2358
Compare
nicknovitski
requested changes
Sep 5, 2024
There was a problem hiding this comment.
Thank you for this! I think it's a good idea, but it will also require removing fetch-mock and using undici's built-in mock features instead.
|
@nicknovitski |
katayama8000
requested review from
douglowder
and removed request for
a team
katayama8000
force-pushed
the
delete_node-fetch
branch
from
43e0d3f to
8ce4503
Compare
|
I switched the branch because fixing the conflicts is difficult. |
|
Closing this in favor of newer PR #116 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.