Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mentoring.md #2308

Closed
wants to merge 1 commit into from
Closed

Update mentoring.md #2308

wants to merge 1 commit into from

Conversation

RomaLetodiani
Copy link
Contributor

No description provided.

@github-actions github-actions bot added track/python Python track type/mentor-notes Mentor notes labels Jan 6, 2024
@IsaacG
Copy link
Member

IsaacG commented Jan 6, 2024

What makes this solution better than the prior one -- for the purpose of mentors?

There are many ways to solve this exercise, and mentors can browse the community solutions if they want to look at other solutions. Does the prior solution not pass the tests? Is there something wrong with it?

@RomaLetodiani
Copy link
Contributor Author

Just wanted to contribute, sry to disturb

@IsaacG
Copy link
Member

IsaacG commented Jan 6, 2024

Contributions are great! But the change should improve something specific and be objectively better. Having everyone update the solution to their solution just to change it doesn't add much value and adds works for maintainers.

@RomaLetodiani
Copy link
Contributor Author

Thx for the feedback i'll close the PR now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
track/python Python track type/mentor-notes Mentor notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants