-
-
Notifications
You must be signed in to change notification settings - Fork 947
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Elm Analyzer comments for concept exercise ticket-please
#2293
Conversation
analyzer-comments/elm/ticket-please/assignTicketTo_ignore_cases.md
Outdated
Show resolved
Hide resolved
analyzer-comments/elm/ticket-please/assignTicketTo_use_record_update.md
Outdated
Show resolved
Hide resolved
@@ -0,0 +1,3 @@ | |||
# destructure assignTicketTo argument | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is only tangential, but I don't think there is any reference to the as
syntax in the concept or exercise docs. I had a google and this cheatsheet was the best source I could find.
https://gist.github.com/yang-wei/4f563fbf81ff843e8b1e#record
Maybe we should add it here, and to the exercise and concept docs, what do you think? Or maybe we should create our own documentation for as
, or open a PR to one of the existing elm documentation sites?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We use it in the last example in the introduction of the concept, and we use this link: https://github.com/izdi/elm-cheat-sheet#operators
Both those links are a bit shabby, so I like the idea of contributing to some docs, but which?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess we can initially explain it will on exercism, in the concept, where we have full control and can do everything.
Those links are shabby, maybe we could put a shout out on the Elm slack? It's possible that any PR to the main slack won't get merged, but maybe elm-programming or something like that would like it ...
Co-authored-by: Cedd Burge <[email protected]>
@exercism/reviewers can I have an approval please? 💛 |
Sister PR over here.
@ceddlyburge can you take a look?
There are quite a few and I wrote these when I was a little too tired for my own good, so please proofread them carefully.