Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[javascript, typescript] replace_magic_with_identifier #2265

Merged
merged 2 commits into from
Aug 29, 2023
Merged

[javascript, typescript] replace_magic_with_identifier #2265

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9830ea6
...facilitates documentation *and translation*.
habere-et-dispertire Aug 25, 2023
68e87a1
...facilitates documentation *and translation*.
habere-et-dispertire Aug 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion analyzer-comments/javascript/general/replace_magic_with_identifier.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,5 +8,5 @@ When possible, named constants are often a better choice than inlined literals b
The programmer might infer the meaning after reading the code carefully, but it is not obvious.
Magic values become particularly confusing when the same value is used for different purposes in one section of code.
- It is easier to alter the value, as it is not duplicated.
- It encourages and facilitates documentation.
- It encourages and facilitates documentation and translation.
- It aids with autocompletion in many IDEs.
2 changes: 1 addition & 1 deletion analyzer-comments/typescript/general/replace_magic_with_identifier.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,5 +8,5 @@ When possible, named constants are often a better choice than inlined literals b
The programmer might infer the meaning after reading the code carefully, but it is not obvious.
Magic values become particularly confusing when the same value is used for different purposes in one section of code.
- It is easier to alter the value, as it is not duplicated.
- It encourages and facilitates documentation.
- It encourages and facilitates documentation and translation.
- It aids with autocompletion in many IDEs.
Loading