Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[csharp/anagram] A reasonable solution for the anagram #2214

Merged
merged 2 commits into from
Feb 16, 2024
Merged

[csharp/anagram] A reasonable solution for the anagram #2214

merged 2 commits into from
Feb 16, 2024

Conversation

michalporeba
Copy link
Contributor

Adding a single reasonable solution for the anagram problem in the csharp track.

@github-actions github-actions bot added track/csharp C# track type/mentor-notes Mentor notes labels Aug 15, 2022
SleeplessByte
SleeplessByte reviewed Feb 16, 2024
View reviewed changes
Copy link
Member

@SleeplessByte SleeplessByte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@exercism/csharp okay with the reasonable solution?

@ErikSchierboom
Copy link
Member

@SleeplessByte I would suggest to add a separate method for .ToLower().OrderBy(character => character), which is called in two places.

@SleeplessByte SleeplessByte changed the title A reasonable solution for the anagram (csharp) [csharp/anagram] A reasonable solution for the anagram Feb 16, 2024
@SleeplessByte SleeplessByte merged commit 70ae430 into exercism:main Feb 16, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SleeplessByte SleeplessByte SleeplessByte approved these changes

Assignees
No one assigned
Labels
track/csharp C# track type/mentor-notes Mentor notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@michalporeba @ErikSchierboom @SleeplessByte