Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create mentoring.md for Say #2211
Create mentoring.md for Say #2211
Changes from 1 commit
22a0d4f
f9fd326
3d07a43
e197f9c
b90d19a
f529f89
f2ea17e
1f655bd
b4bdd43
9cc2d9a
d0119e4
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there data to support this claim? Does this claim help the mentor? What is the purpose of this sentence?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line 85? I would have thought indexing a string would be easier for most students than using numeric operators to isolate a particular digit, but you're right that it's just my intuition, so I'll update that line.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure this list of functions is super helpful when mentoring an exercise. As a mentor, I'd want to see discussions on approaches and solutions at a higher level, not specific string methods which may or may not be useful here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do see your point about the specificity of some lines - 97, 99-101 are probably unnecessary. But since there's a lot going on in this exercise, I figured having a list of suggested techniques would be helpful as a quick reference - if a mentor scans this list before reading the student's code they'll more likely spot that a certain piece of code might make use of something here and be a good opportunity to introduce it to the student. Otherwise many of these wouldn't come to mind without more time spent on the exercise. I think it can be quite helpful to be introduced to a technique through a real example where it improves the code you've already written - getting a sense of when some of these would be useful is harder in contrived examples imo, but for slightly less common constructions it's easy to miss good opportunities to teach them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seperator -> separator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This code uses both double quotes and single quotes. Either is fine, but avoid mixing and matching! Consistent code is good code.
I'm also not sure what the value of this code block is. Is there something specific this is calling to a mentor's attention?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I've fixed the quotes.
Basically since there's a lot of different techniques that can be applied here I wanted to give a third example to cover some more of them. It isn't necessarily intended to show best practice, but some of the techniques used would be suitable for a student to use. I put it at the end because there's already two examples at the top.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
10 <= n < 20