[Clojure]: reverse-string: Mentor note update #2191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think using what is arguably an implementation detail of list (i.e. that it appends at the start) is fine but not as explicit and obvious as `(apply str (reverse s))`.
github-actions
bot
added
track/clojure
kotp
changed the title
(apply str (reverse s)) expresses the intent more clearly
kotp
changed the title
kotp
reviewed
May 21, 2022
SleeplessByte
approved these changes
Feb 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my mind
(apply str (reverse s))expresses the intent more clearly.I think using what is arguably an implementation detail of list (i.e. that it appends at the start) is fine but not as explicit and obvious as
(apply str (reverse s)).