Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Approaches roman num2 #320

Merged
merged 3 commits into from
Feb 3, 2024
Merged

Approaches roman num2 #320

merged 3 commits into from
Feb 3, 2024

Conversation

colinleach
Copy link
Contributor

Not for the first time, I got in a tangle with rebase/merge and found it easier to create a new branch. I think this one should be clean.

jonmcalder
jonmcalder approved these changes Feb 3, 2024
View reviewed changes
Copy link
Member

@jonmcalder jonmcalder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry to hear about the rebasing woes again 🙈
Hopefully it'll get easier (or just happen less) over time.

Just the one small typo here but otherwise I think these articles look great. Thanks so much!

exercises/practice/roman-numerals/.approaches/introduction.md Outdated Show resolved Hide resolved
@colinleach colinleach merged commit 8741006 into exercism:main Feb 3, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonmcalder jonmcalder jonmcalder approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@colinleach @jonmcalder