-
-
Notifications
You must be signed in to change notification settings - Fork 625
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prerequisites for acronym exercise #1577
Prerequisites for acronym exercise #1577
Conversation
Dear AnishDe12020Thank you for contributing to the JavaScript track on Exercism! 💙
Dear Reviewer/Maintainer
Automated comment created by PR Commenter 🤖. |
config.json
Outdated
"array-transformations", | ||
"rest-and-spread", | ||
"classes" | ||
], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like the main branch is not merged to your branch as I thought this is merged by now. 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, I think I have figured out the mistake, it is on my side. I had checked out to this branch from the high scores branch instead of first checking out to the main branch. I am not sure what to do.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here is how I fix these issues:
- Go to the main branch
git checkout main
and pull the latest changesgit pull upstream main
(this is also available via the GitHub UI). - Switch back to your branch and merge the main branch
git merge main
. - Push the changes. Then the part that is already in the main branch is not in the diff of the PR anymore.
I did this for you here so I can merge this now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh cool. I will make sure to do this if it happens next time. Thanks for the reply 😃
I have added the prerequisites for the acronym practice exercise.
references #984