Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prerequisites for acronym exercise #1577

Merged

Conversation

AnishDe12020
Copy link
Contributor

I have added the prerequisites for the acronym practice exercise.
references #984

@github-actions
Copy link
Contributor

Dear AnishDe12020

Thank you for contributing to the JavaScript track on Exercism! 💙
You will see some automated feedback below 🤖. It would be great if you can make sure your PR covers those points. This will save your reviewer some time and your change can be merged quicker.

  • ✍️ If your PR is not related to an existing issue (and is not self-explaining like a typo fix), please make sure the description explains why the change you made is necessary.

  • 🔤 If your PR fixes an easy to identify typo, if would be great if you could check for that typo in the whole repo. For example, if you found Unicdoe, use "replace all" in your editor (or command line magic) to fix it consistently.

Dear Reviewer/Maintainer

  • 📏 Make sure you set the appropriate x:size label for the PR. (This also works after merging, in case you forgot about it.)

  • 🔍 Don't be too nit-picky. If the PR is a clear improvement compared to the status quo, it should be approved as clear signal this is good to be merged even if the minor comments you might have are not addressed by the contributor. Further improvement ideas can be captured in issues (if important enough) and implemented via additional PRs.

  • 🤔 After reviewing the diff in the "Files changed" section, take a moment to think about whether there are changes missing from the diff. Does something need to be adjusted in other places so the code or content stays consistent?

Automated comment created by PR Commenter 🤖.

@junedev junedev added the x:size/small Small amount of work label Dec 23, 2021
config.json Outdated
"array-transformations",
"rest-and-spread",
"classes"
],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the main branch is not merged to your branch as I thought this is merged by now. 🤔

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I think I have figured out the mistake, it is on my side. I had checked out to this branch from the high scores branch instead of first checking out to the main branch. I am not sure what to do.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is how I fix these issues:

  1. Go to the main branch git checkout main and pull the latest changes git pull upstream main (this is also available via the GitHub UI).
  2. Switch back to your branch and merge the main branch git merge main.
  3. Push the changes. Then the part that is already in the main branch is not in the diff of the PR anymore.

I did this for you here so I can merge this now.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh cool. I will make sure to do this if it happens next time. Thanks for the reply 😃

config.json Outdated Show resolved Hide resolved
@junedev junedev merged commit e723994 into exercism:main Dec 26, 2021
@AnishDe12020 AnishDe12020 deleted the practice-exercise-prequisities-acronym branch December 26, 2021 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
x:size/small Small amount of work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants